Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New/Updated door sprites #5674

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

thedyze
Copy link
Contributor

@thedyze thedyze commented Nov 5, 2024

Checklist

Required

Optional

  • I have documented the changes in the appropriate location in the doc/ folder.

Purpose of change

To improve door graphics. The current ones were quite lacking in contrast and polish.

Describe the solution

Added new door sprites or updated existing ones.

doors_final

Describe alternatives you've considered

Redoing all the door. Ran out of steam, so there still is some future work to do.

Testing

Spawning doors with the terrain editor.

@github-actions github-actions bot added docs PRs releated to docs page JSON related to game datas in JSON format. labels Nov 5, 2024
RoyalFox2140
RoyalFox2140 previously approved these changes Nov 5, 2024
@chaosvolt chaosvolt merged commit 2b065ad into cataclysmbnteam:main Nov 6, 2024
9 checks passed
@thedyze thedyze deleted the doorSpites branch November 6, 2024 22:33
@NobleJake
Copy link
Contributor

NobleJake commented Nov 10, 2024

@thedyze The new doors and the sharpened floor tile colors are nice individually, but as you can see in the photo, they look awkwardly out of place as a whole, like they belong in an RPG Maker game, not an Undead people tiles. I think it would be a good idea to break out these tiles as mod for those who want the old tile styles.

@RoyalFox2140
Copy link
Collaborator

@thedyze The new doors and the sharpened floor tile colors are nice individually, but as you can see in the photo, they look awkwardly out of place as a whole, like they belong in an RPG Maker game, not an Undead people tiles. I think it would be a good idea to break out these tiles as mod for those who want the old tile styles.

Then delete them from your files.

@thedyze
Copy link
Contributor Author

thedyze commented Nov 10, 2024

@thedyze The new doors and the sharpened floor tile colors are nice individually, but as you can see in the photo, they look awkwardly out of place as a whole, like they belong in an RPG Maker game, not an Undead people tiles. I think it would be a good idea to break out these tiles as mod for those who want the old tile styles.

I'm gonna respond here for "official" reasons. There is an ongoing discussion on Discord regarding this.
When leaving feedback (which I very much appreciate) it would be a lot more constructive if the following points are taken into account.

  • Post the comment while the PR is open (or ping me on Discord) so I have a chance to easily make adjustments.
  • Be precise in your feedback, and suggest changes to the sprites that in your opinion would improve it. Sweeping statements are really not that helpful.
  • Take part in the development channel on Discord as I generally post sprites there while they are still wip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PRs releated to docs page JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants