updated requirements to include cv2 and update dev testing locations for neuroconv #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauladkisson
changed the title
h-mayorquin
approved these changes
Sep 12, 2024
| @@ -1,5 +1,8 @@ | |||
| tifffile>=2018.10.18 | |||
| scanimage-tiff-reader>=1.4.1.4 | |||
| neuroconv[video]>=0.4.6 # Uses the VideoCaptureContext class | |||
| opencv-python-headless>=4.5.1.48 | |||
There was a problem hiding this comment.
Isn't this included in neuroconv video?
It might be a good idea to make it explicit though, do other extractors require it?
There was a problem hiding this comment.
I thought it would've been, but the tests were failing bc opencv wasn't installed.
There was a problem hiding this comment.
I would be concerned if this is related to the recent changes to pyproject.toml, when did the test start to fail?
There was a problem hiding this comment.
Ok, then it sounds unlikely. Still strange. Probably not worth finding out if this is working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failing dailies
Fixes failing dev tests