Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated requirements to include cv2 and update dev testing locations for neuroconv #357

Merged
merged 3 commits into from
Sep 13, 2024
Merged

updated requirements to include cv2 and update dev testing locations for neuroconv #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09dc8e0
updated requirements to include cv2
pauladkisson Sep 11, 2024
366986f
updated dev testing locations
pauladkisson Sep 12, 2024
762441d
updated changelog
pauladkisson Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dev-testing.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ jobs:

- name: Run NeuroConv tests
run: |
pytest -n auto --dist loadscope neuroconv/tests/test_ophys neuroconv/tests/test_on_data/test_imaging_interfaces.py neuroconv/tests/test_on_data/test_segmentation_interfaces.py
pytest -n auto --dist loadscope neuroconv/tests/test_ophys neuroconv/tests/test_on_data/ophys/test_imaging_interfaces.py neuroconv/tests/test_on_data/ophys/test_segmentation_interfaces.py
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
* Change the criteria of determining if Bruker data is volumetric [#342](https://github.com/catalystneuro/roiextractors/pull/342)
* Fixes a bug that assumes the channel name is is on the tiff file for `BrukerTiffSinglePlaneImagingExtractor` [#343](https://github.com/catalystneuro/roiextractors/pull/343)
* Including `packaging` explicitly in minimal requirements [#347](https://github.com/catalystneuro/roiextractors/pull/347)
* Updated requirements to include cv2 and update dev testing locations for neuroconv: [#357](https://github.com/catalystneuro/roiextractors/pull/357)

### Improvements

Expand Down
3 changes: 3 additions & 0 deletions requirements-full.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
tifffile>=2018.10.18
scanimage-tiff-reader>=1.4.1.4
neuroconv[video]>=0.4.6 # Uses the VideoCaptureContext class
opencv-python-headless>=4.5.1.48
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this included in neuroconv video?

It might be a good idea to make it explicit though, do other extractors require it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would've been, but the tests were failing bc opencv wasn't installed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be concerned if this is related to the recent changes to pyproject.toml, when did the test start to fail?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yesterday

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then it sounds unlikely. Still strange. Probably not worth finding out if this is working.

opencv-python-headless>=4.5.1.48,<4.7.0.72; sys_platform == 'darwin'
opencv-python-headless>=4.5.1.48,<4.7; sys_platform == 'darwin' and python_version>='3.11'
natsort>=8.3.1
isx>=1.0.4
Loading