Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test hpandas dassert_is_days #1076

Closed
sonaalKant opened this issue Jul 10, 2024 · 9 comments
Closed

Unit test hpandas dassert_is_days #1076

sonaalKant opened this issue Jul 10, 2024 · 9 comments
Assignees

Comments

@sonaalKant
Copy link
Collaborator

Lets test the method to show all assert cases are caught.

https://github.com/kaizen-ai/kaizenflow/blob/bc8bf878faa174a77c5d23fe7976de7307b1d717/helpers/hpandas.py#L72

Steps:

  1. Create multiple mock inputs and verify that all the dassert catches the invalid inputs correctly.
  2. Follow the DRY principle to avoid writing repeated code.
    FYI @samarth9008
@mihir1906
Copy link
Contributor

Hello @samarth9008, I installed Docker and confirmed the installation, but I'm having trouble starting the container. Despite using the i docker_bash command and checking with docker ps, I don’t see any containers listed. Could you please guide me on how to properly start the container and troubleshoot why it’s not appearing? Thanks!

(amp.client_venv) mihir@mihir-VMware-Virtual-Platform:~/src/kaizenflow1$ sudo docker ps
[sudo] password for mihir:
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES

@samarth9008
Copy link
Collaborator

This was supposed to be asked during the on-boarding issue and not warm-up

No need to run docker using sudo. Pls change the permissions accordingly

Can you do docker image ls to see if the required docker image is present?

@mihir1906
Copy link
Contributor

Hi @samarth9008,

I apologize for not addressing this during the onboarding process. I have now updated the permissions to ensure Docker can be run without sudo.

Regarding your request, here is the output of the docker image ls to verify the presence of the required Docker image:
REPOSITORY TAG IMAGE ID CREATED SIZE
hello-world latest d2c94e258dcb 14 months ago 13.3kB

@samarth9008
Copy link
Collaborator

You don't have the image required to do the development work. Pls go through onboarding docs to set up the dev env. Take help from Shaunak if needed since I believe he is the you know if I am not wrong.

@mihir1906
Copy link
Contributor

I now have the necessary image for development, and I successfully rebuilt the virtual environment, resolving the issues with the requirements.txt file.

(amp.client_venv) mihir@mihir-VMware-Virtual-Platform:~/src/kaizenflow1$ docker image ls
REPOSITORY TAG IMAGE ID CREATED SIZE
sorrentum/cmamp dev 636ef21caffc 4 months ago 3.54GB
sorrentum/dev_tools prod 9be81a121a9d 7 months ago 4.24GB
hello-world latest d2c94e258dcb 14 months ago 13.3kB

Additionally, the container now starts with the i docker_bash command, and the terminal appears as follows. Please confirm if this is correct.

21:08:43 - INFO hcache.py clear_global_cache:294 Before clear_global_cache: 'global mem' cache: path='/mnt/tmpfs/tmp.cache.mem', size=36.0 KB
21:08:43 - WARN hcache.py clear_global_cache:295 Resetting 'global mem' cache '/mnt/tmpfs/tmp.cache.mem'
21:08:43 - WARN hcache.py clear_global_cache:305 Destroying '/mnt/tmpfs/tmp.cache.mem' ...
21:08:43 - INFO hcache.py clear_global_cache:321 After clear_global_cache: 'global mem' cache: path='/mnt/tmpfs/tmp.cache.mem', size=nan
user_1000@7b2bd7e9b03f:/app$

@samarth9008
Copy link
Collaborator

Yes it is correct.

@gpsaggese
Copy link
Contributor

As @samarth9008 said, let's make sure that the onboarding is complete. We want to separate setting up the environment from making progress, otherwise there is interference btw tasks.

@mihir1906
Copy link
Contributor

I apologize for any inconvenience caused. I ensure that the onboarding is fully complete and will be proceeding with the warm-up issue, preventing any interference.

samarth9008 pushed a commit that referenced this issue Aug 15, 2024
* Updated test_hpandas with unit testing code for dassert is days

* Updated test_hpandas with unit testing code for dassert is days

* Addressed review feedback and fixed code alignment issues

* removed empty lines and added ended comments with full stops.

* Comment reformating and resolving merge conflicts.

* Restored requirements.txt to match the master branch

* Restored the class Test_dassert_valid_remap.

* Fixed requested minor nits in comments.
@samarth9008
Copy link
Collaborator

done, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants