Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kaizen task1076 unit test hpandas dassert is days #1076 #1102

Merged
merged 17 commits into from
Aug 15, 2024
Merged

Kaizen task1076 unit test hpandas dassert is days #1076 #1102

merged 17 commits into from
Aug 15, 2024

Conversation

mihir1906
Copy link
Contributor

Created this PR for Issue #1076

Changes Made:

Implemented unit tests for dassert_is_days

Testing:
Ran code through pylint and pytest.

test/test_hpandas.py::Test_dassert_is_days::test1 (0.00 s) PASSED                                                                                                                             [ 11%]
test/test_hpandas.py::Test_dassert_is_days::test2 (0.00 s) PASSED                                                                                                                             [ 22%]
test/test_hpandas.py::Test_dassert_is_days::test3 (0.00 s) PASSED                                                                                                                             [ 33%]
test/test_hpandas.py::Test_dassert_is_days::test4 (0.00 s) PASSED                                                                                                                             [ 44%]
test/test_hpandas.py::Test_dassert_is_days::test5 (0.00 s) PASSED                                                                                                                             [ 55%]
test/test_hpandas.py::Test_dassert_is_days::test6 (0.00 s) PASSED                                                                                                                             [ 66%]
test/test_hpandas.py::Test_dassert_is_days::test7 (0.00 s) PASSED                                                                                                                             [ 77%]
test/test_hpandas.py::Test_dassert_is_days::test8 (0.00 s) PASSED                                                                                                                             [ 88%]
test/test_hpandas.py::Test_dassert_is_days::test9 (0.00 s) PASSED                                                                                                                             [100%]

@samarth9008 please do let me know incase of any further suggestions/changes.

@mihir1906 mihir1906 self-assigned this Jul 25, 2024
samarth9008
samarth9008 reviewed Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@samarth9008 samarth9008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first PR, few nits from my side.

dev_scripts/client_setup/requirements.txt Outdated Show resolved Hide resolved
helpers/test/test_hpandas.py Outdated Show resolved Hide resolved
helpers/test/test_hpandas.py Outdated Show resolved Hide resolved
helpers/test/test_hpandas.py Show resolved Hide resolved
helpers/test/test_hpandas.py Outdated Show resolved Hide resolved
helpers/test/test_hpandas.py Outdated Show resolved Hide resolved
@mihir1906 mihir1906 requested a review from samarth9008 July 29, 2024 14:07
gpsaggese
gpsaggese reviewed Jul 30, 2024
View reviewed changes
helpers/test/test_hpandas.py Outdated Show resolved Hide resolved
helpers/test/test_hpandas.py Outdated Show resolved Hide resolved
helpers/test/test_hpandas.py Outdated Show resolved Hide resolved
@mihir1906 mihir1906 requested a review from gpsaggese July 31, 2024 08:39
sonaalKant
sonaalKant approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@sonaalKant sonaalKant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mihir1906
Copy link
Contributor Author

LGTM.

Thank you for the approval!

gpsaggese
gpsaggese reviewed Aug 3, 2024
View reviewed changes
Copy link
Contributor

@gpsaggese gpsaggese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes and merge

helpers/test/test_hpandas.py Outdated Show resolved Hide resolved
dev_scripts/client_setup/requirements.txt Outdated Show resolved Hide resolved
@mihir1906 mihir1906 requested a review from gpsaggese August 5, 2024 20:27
@mihir1906 mihir1906 requested a review from sonaalKant August 14, 2024 18:39
@mihir1906 mihir1906 requested a review from samarth9008 August 15, 2024 16:17
samarth9008
samarth9008 reviewed Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@samarth9008 samarth9008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

helpers/test/test_hpandas.py Outdated Show resolved Hide resolved
helpers/test/test_hpandas.py Outdated Show resolved Hide resolved
helpers/test/test_hpandas.py Outdated Show resolved Hide resolved
@mihir1906 mihir1906 requested a review from samarth9008 August 15, 2024 17:16
samarth9008
samarth9008 reviewed Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@samarth9008 samarth9008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@samarth9008 samarth9008 merged commit d414acd into master Aug 15, 2024
1 check passed
@samarth9008 samarth9008 deleted the KaizenTask1076_Unit_test_hpandas_dassert_is_days branch August 15, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarth9008 samarth9008 samarth9008 left review comments

@Shaunak01 Shaunak01 Awaiting requested review from Shaunak01

@gpsaggese gpsaggese Awaiting requested review from gpsaggese

@sonaalKant sonaalKant Awaiting requested review from sonaalKant

Assignees

@mihir1906 mihir1906

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mihir1906 @sonaalKant @gpsaggese @samarth9008