Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Branch #936

Merged

Conversation

Nadiyahlw
Copy link
Collaborator

Trying to be up to date with the Master Branch

Shaunak01 and others added 5 commits April 29, 2024 08:20
* Added Unit test for split_positive_and_negative_parts()

* Resolved comments

* Added remaining comments

* deleted unnecessary files

* "Fixes"

* Comment resolution

* Comments resolved.

---------

Co-authored-by: Samarth KaPatel <samarth.kapatel5@gmail.com>
* Issue #782 draft PR with code skeleton

* Issue #782 unit tests for function calculate_vwap_twap with 2 different resampling rules

* Fix for ambiguous truth value of multiindex column names

* Linter corrections on file

* Changes for PR comment

* Modifications to address PR comments

* Adding full-stop to comments

---------

Co-authored-by: Aishwarya Nidhi <aishwaryanidhi@Aishwaryas-Air.cgocable.net>
Co-authored-by: Samarth KaPatel <samarth.kapatel5@gmail.com>
* Issue 891 - Unit test code skeleton

* Issue-891 3 unit tests with each available unit value for Series input.

* Issue-891 Unit test of compute epoch function for dataframe input with default unit

* Adding missed full stop for comment

* PR comment fixes

* Removing todo from function

* PR comment fixes

---------

Co-authored-by: Aishwarya Nidhi <aishwaryanidhi@Aishwaryas-Air.cgocable.net>
Co-authored-by: Samarth KaPatel <samarth.kapatel5@gmail.com>
* Added unit test for function convert_seconds_to_minutes

* Nits
@Nadiyahlw Nadiyahlw merged commit fd6004c into rSorrTask886_Spring2024_simple_data_analysis_with_orm May 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants