-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gizmo JSON-LD Content Type #821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks great, thanks @iddan! :)
However it will break all clients. As with the previous PR, we can add it in a compatible manner. I think we can switch on Accept
header of incoming requests and serve the new format specifically for Accept: application/ld+json
. We can then land this change to v0.7.6 and switch to JSON-LD by default in v0.8.
What do you think?
It will be awesome! Can you help me to do that? |
Sure, will try to push changes to the same branch. |
@iddan I rebased your branch and exposed the new code path when Can you please fix tests and check if HTTP endpoint returns what we expect? I used this command to test it:
|
Sure, will do it soon. |
@dennwc tests are fixed, the response was checked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied some Git magic to rebase/squash unnecessary commits, ready to merge now. Thanks again @iddan! :)
This change is
Todo