Define and implement a new query interface #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current query interface (in Go) is weird. The user must know that
Executeshould be called in a goroutine, and then returned values should beCollated. This is a very non-intuitive way to expose query results.This PR defines a new interface that returns a regular iterator. The type of query results is controlled by an option. This way the query language will collate value internally, providing only useful values to the user.
This is a breaking change, since it replaces the old interface completely. However, internal query interface was not documented, and was not intended for external use, so I think it's worth changing anyway.
This change also adds an extendable
Optionsparameter toExecute, unlocking future progress on #821.This change is