Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify trailing zeros for weekly data (2023-12-31) #131

Closed
jeanpaulrsoucy opened this issue Jan 12, 2024 · 1 comment
Closed

Verify trailing zeros for weekly data (2023-12-31) #131

jeanpaulrsoucy opened this issue Jan 12, 2024 · 1 comment
Labels
bug Something isn't working data New data sources or updates to existing data sources.

Comments

@jeanpaulrsoucy
Copy link
Member

The current setup may produce some trailing zeros for 2023-12-31 for datasets where all data for the week are reported on a single date (e.g., Alberta, weekly reports). Prior to finalizing data updates, these trailing zeros (for 2023-12-31, since most of these dataset's final good update will be update to the last Saturday, 2023-12-30) should be trimmed.

@jeanpaulrsoucy jeanpaulrsoucy added data New data sources or updates to existing data sources. bug Something isn't working labels Jan 12, 2024
@jeanpaulrsoucy
Copy link
Member Author

jeanpaulrsoucy commented Jan 23, 2024

The following metric/PT combos are affected:

cases

  • AB
  • NB
  • NL
  • PE
  • SK

deaths

  • AB
  • MB
  • ON (HR-level only)
  • PE
  • SK

hospitalizations

  • CAN (this is technically daily even if these particular values were static for 2023-12-31)
  • BC (2023-12-21)

icu

  • CAN (this is technically daily even if these particular values were static for 2023-12-31)
  • BC (2023-12-21)

hosp_admissions

  • AB
  • ON
  • SK

icu_admissions

  • AB
  • SK

tests_completed

  • AB
  • BC
  • MB
  • NS
  • ON
  • PE
  • SK

Functions returning PHAC data could be updated to return no data later than 2023-12-30.

Should wait for final updates on vaccine coverage and vaccine administration data. The completeness JSON datasets should also be trimmed.

jeanpaulrsoucy added a commit to ccodwg/Covid19CanadaETL that referenced this issue Jan 23, 2024
- Add `max_date()` function for trimming to a specified max date
- Limit date of returned data for `get_phac_d()` weekly datasets
- ccodwg/CovidTimelineCanada#131
jeanpaulrsoucy added a commit that referenced this issue Jan 23, 2024
- Update data source end dates to remove trailing zeroes (#117, #131)
jeanpaulrsoucy added a commit to ccodwg/Covid19CanadaETL that referenced this issue Jan 27, 2024
jeanpaulrsoucy added a commit that referenced this issue Jan 27, 2024
- Update vaccine coverage data to end on 2023-09-10 for all PTs (except QC), since this is the last date that all vaccine dose coverage values were reported (in particular, dose 2 coverage is excluded after this date) (#21)
- Update vaccine distribution data with appropriate end dates and sources (#22)
jeanpaulrsoucy added a commit that referenced this issue Jan 27, 2024
- Final update of vaccine administration data is 2023-12-03, as the next update will be in 2024 (#47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data New data sources or updates to existing data sources.
Projects
None yet
Development

No branches or pull requests

1 participant