Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-image masks in nexus. Resolves #308. #315

Merged
merged 2 commits into from
Apr 4, 2019

Conversation

phyy-nx
Copy link
Contributor

@phyy-nx phyy-nx commented Apr 3, 2019

Now that nexusformat/definitions#654 is merged, we can add the multi-image mask to the nexus format class.

@phyy-nx phyy-nx requested a review from jmp1985 April 3, 2019 16:41
@phyy-nx phyy-nx force-pushed the nexus_multiimage_mask branch from 8f179c2 to 72554d7 Compare April 3, 2019 19:09
@ndevenish ndevenish added the dxtbx label Apr 4, 2019
@phyy-nx
Copy link
Contributor Author

phyy-nx commented Apr 4, 2019

Hoping to merge this later today :)

Copy link
Contributor

@jmp1985 jmp1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Aaron, this looks fine to me :)

@phyy-nx phyy-nx merged commit f75bd6a into master Apr 4, 2019
@phyy-nx phyy-nx deleted the nexus_multiimage_mask branch April 4, 2019 15:45
@phyy-nx
Copy link
Contributor Author

phyy-nx commented Apr 4, 2019

Thanks. I have no more pending dxtbx changes. I'll start looking at the dxtbx move branch later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants