Allow multi-image masks. Resolves #651. #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also sync some of the documentation between NXdetector and NXmx.
|
@graeme-winter has argued we want a separate dynamic_mask. Closing this for now, but it can be reopened pending discussion. |
This was referenced Mar 29, 2019
|
This pull request only clarifies the status quo. I see no reason to not merge this. |
|
Hey, so this would be independent then of whether #655 is merged in? If so, I'll merge in an hour and we can let the issue of whether to add a dynamic mask have some more discussion, if needed. |
|
Again, a day for final review is recommended. |
|
👍
…On Tue, Apr 2, 2019 at 9:13 AM Pete R Jemian ***@***.***> wrote:
Again
<#652 (comment)>,
a day for final review is recommended.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#654 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AM2OyqQDEYi8R6Ert4p5yO1cNyp8oeQpks5vc4GagaJpZM4cRIlr>
.
|
|
So, in people words you are allowing the dimensionality of pixel_mask to be extended to the same dimensionality of the data set, then the other PR is to add what is effectively a second mask? Makes sense to me. |
|
Yep. I don’t see why we can’t have both, if there is a good use case like this.
…-Aaron
On Apr 2, 2019, at 11:40 PM, Graeme Winter ***@***.***> wrote:
So, in people words you are allowing the dimensionality of pixel_mask to be extended to the same dimensionality of the data set, then the other PR is to add what is effectively a second mask? Makes sense to me.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
zjttoefs
approved these changes
Apr 3, 2019
|
Thanks all. |
phyy-nx
added a commit
that referenced
this pull request
Apr 3, 2019
phyy-nx
added a commit
that referenced
this pull request
Jul 30, 2019
phyy-nx
added a commit
that referenced
this pull request
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putative solution for multi-image masks and a proposed solution to the issues raised here: https://github.com/HDRMX/NXmx/wiki/Treatment-of-(Dynamic)-Shadows-in-Eiger-Data-Sets
Adds this text: Can be either one mask for the whole dataset (rank i, j, k) or each frame can have its own mask (rank np, i, j, k).
Also sync some of the documentation between NXdetector and NXmx.