Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 640kbps audio #195

Closed
Harybo opened this issue Jan 31, 2021 · 6 comments
Closed

Add 640kbps audio #195

Harybo opened this issue Jan 31, 2021 · 6 comments
Labels
enhancement Improve existing feature

Comments

@Harybo
Copy link

Harybo commented Jan 31, 2021

Hey,

would it be possible to add 640kbps audio support which is already supported by handbrake and staxrip
@cdgriffith cdgriffith added the enhancement Improve existing feature label Jan 31, 2021
@cdgriffith
Copy link
Owner

The current logic is that it will give options in a range of 32K per channel differences, that will be lowered to 16K per channel to have a lot more options in 4.2.0. (For example 8 channel options, like 7.1, will have 640k. Whereas 6 channels, like 5.1 would have closest 672k, so they are divisible by 16)

@E-t-z
Copy link

E-t-z commented Jan 31, 2021 •
edited
Loading

@cdgriffith for AC3 it would be out of spec.. 😄

AC3 (Dolby Digital/ Dolbby Digital EX) bitrates are supported up to 640, most common is 448/640 for 5.1 or 192/256 for 2.0
Everything above 640, will violate AC3 specification.
At the moment it is not even possible to pick 448/640 in FastFlix and I'm not talking about downmixing (current logic seems to work fine there).

See here: https://en.wikipedia.org/wiki/Dolby_Digital#Dolby_technologies_in_packaged_media_formats

@cdgriffith
Copy link
Owner

Good to know! I hope someday to do a big audio overhaul and add filters / vbr / custom rates / etc... but that's quite few months away probably.

@E-t-z
Copy link

E-t-z commented Jan 31, 2021 •
edited
Loading

Thats great, but I see one caveat here.
You would have to go through all audio codec specifications you plan to support (and define some sort of profile system, behind the scenes).
Or simply leave it to user and allow them to do, whatever they want and encoding things into something, which nothing would be able to play back... 😆

@ObviousInRetrospect
Copy link
Contributor

I added 640k in this pull request: #287

cdgriffith pushed a commit that referenced this issue Jan 20, 2022
@ObviousInRetrospect
Fix parsing of output with -psnr on and add 640k audio bitrate (#287)
c7e2572 
* Adding #195 640kbps audio (thanks to ObviousInRetrospect and Harybo)
* Fixing status parser when using -psnr (thanks to ObviousInRetrospect)

Co-authored-by: ObviousInRetrospect <42229858+obviousinretrospect@users.noreply.github.com>
@cdgriffith cdgriffith mentioned this issue Jan 23, 2022
Merged
cdgriffith added a commit that referenced this issue Jan 25, 2022
@cdgriffith @ObviousInRetrospect
Version 4.6.0 (#286)
4b7e9a6 
* Adding #195 640kbps audio (thanks to ObviousInRetrospect and Harybo)
* Adding Japanese, Portuguese, Russian, Swedish, and Polish translations
* Fixing #272 Codec drop down size fix (thanks to kachijs)
* Fixing #278 FastFlix occasionally getting stuck on a single video in a queue (thanks to kamild_)
* Fixing build for 3.10 by updating to PySide6 6.2.2.1 (thanks to Nhunz)
* Fixing status parser when using -psnr (thanks to ObviousInRetrospect)
* Fixing VCE and NVENC encoders would set first subtitle track to default

Co-authored-by: ObviousInRetrospect <42229858+obviousinretrospect@users.noreply.github.com>
@cdgriffith
Copy link
Owner

Added in https://github.com/cdgriffith/FastFlix/releases/tag/4.6.0 thanks to @ObviousInRetrospect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improve existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cdgriffith @E-t-z @Harybo @ObviousInRetrospect