-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 640kbps audio #195
Comments
The current logic is that it will give options in a range of 32K per channel differences, that will be lowered to 16K per channel to have a lot more options in 4.2.0. (For example 8 channel options, like 7.1, will have 640k. Whereas 6 channels, like 5.1 would have closest 672k, so they are divisible by 16) |
@cdgriffith for AC3 it would be out of spec.. 😄 AC3 (Dolby Digital/ Dolbby Digital EX) bitrates are supported up to 640, most common is 448/640 for 5.1 or 192/256 for 2.0 See here: https://en.wikipedia.org/wiki/Dolby_Digital#Dolby_technologies_in_packaged_media_formats |
Good to know! I hope someday to do a big audio overhaul and add filters / vbr / custom rates / etc... but that's quite few months away probably. |
Thats great, but I see one caveat here. |
I added 640k in this pull request: #287 |
* Adding #195 640kbps audio (thanks to ObviousInRetrospect and Harybo) * Fixing status parser when using -psnr (thanks to ObviousInRetrospect) Co-authored-by: ObviousInRetrospect <42229858+obviousinretrospect@users.noreply.github.com>
* Adding #195 640kbps audio (thanks to ObviousInRetrospect and Harybo) * Adding Japanese, Portuguese, Russian, Swedish, and Polish translations * Fixing #272 Codec drop down size fix (thanks to kachijs) * Fixing #278 FastFlix occasionally getting stuck on a single video in a queue (thanks to kamild_) * Fixing build for 3.10 by updating to PySide6 6.2.2.1 (thanks to Nhunz) * Fixing status parser when using -psnr (thanks to ObviousInRetrospect) * Fixing VCE and NVENC encoders would set first subtitle track to default Co-authored-by: ObviousInRetrospect <42229858+obviousinretrospect@users.noreply.github.com>
Hey,
would it be possible to add 640kbps audio support which is already supported by handbrake and staxrip
The text was updated successfully, but these errors were encountered: