Fix parsing of output with -psnr on and add 640k audio bitrate #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-psnr causes output of PSNR=Y:nan U:nan V:nan *:nan which breaks the current parser. Treat the = split differently. Also 640k is a very standard and well supported bitrate. It is the max for AC3 and is a required bitrate for bluray. Add it and simplify the channels not specified case (the old list was the same as channels=2).
Closed
black check passes
Adding info to Chagelog.
|
Thank you so much for these fixes @ObviousInRetrospect, will make sure they are in next release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-psnr causes output of PSNR=Y:nan U:nan V:nan *:nan which breaks the current parser. Treat the = split differently.
Also 640k is a very standard and well supported audio bitrate. It is the max for AC3 and is a required bitrate for bluray. Add it and simplify the channels not specified case (the old list was the same increment as channels=2).