Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NVEncC burned in subtitles wrong size #218

Closed
wynterca opened this issue May 3, 2021 · 2 comments
Closed

NVEncC burned in subtitles wrong size #218

wynterca opened this issue May 3, 2021 · 2 comments
Labels
enhancement Improve existing feature

Comments

@wynterca
Copy link

wynterca commented May 3, 2021

No description provided.

@wynterca
Copy link
Author

wynterca commented May 3, 2021

When burning sub title track into the video using NVEncC for 4k video may require "--vpp-subburn track=2,scale=2.0" so the subs aren't half sized

@wynterca wynterca changed the title NVncC NVEncC burned in subtitles wrong size May 3, 2021
@cdgriffith cdgriffith added the enhancement Improve existing feature label May 3, 2021
cdgriffith added a commit that referenced this issue Jul 20, 2022
@cdgriffith
* Adding #322 warning if profile audio match doesn't match anything (…
7237194 
…thanks to wynterca)

* Fixing #319 no longer disables built in tracks for profile matching (thanks to Owen Quinlan)
* Fixing #218 and #308 subtitle scaling with rigaya's hardware encoders needs to be scaled for 4K content (thanks to wynterca)
@cdgriffith cdgriffith mentioned this issue Jul 20, 2022
Merged
cdgriffith added a commit that referenced this issue Jul 21, 2022
@cdgriffith @leonardyan
Version 4.10.0 (#360)
ec54941 
* Adding AVIF support using libsvtav1
* Adding #352 default output directory to settings panel (thanks to Maddie Davis)
* Adding #306 support for audio profiles with pattern matching for rigaya's hardware encoders
* Adding #301 Select All feature for subtitles (thanks to ProFire and Genine-Collin)
* Adding #325 build for Ubuntu 22.04 (thanks to mrjayviper)
* Adding build for MacOS 12
* Adding #322 warning if profile audio match doesn't match anything (thanks to wynterca)
* Adding presumption that 4.x branch is last to support Windows 7 and 8 for update checks
* Fixing #319 no longer disables built in tracks for profile matching (thanks to Owen Quinlan)
* Fixing #218 and #308 subtitle scaling with rigaya's hardware encoders needs to be scaled for 4K content (thanks to wynterca)
* Fixing #350 subtitle burn in quoting (thanks to Maddie Davis)
* Fixing #346 preserve the order of audio tracks when editing a queued job (thanks to Patrick Bassner)
* Fixing #187 closing the main app while a progress bar is active will now stop that task (thanks to Todd Wilkinson)
* Fixing Chinese translations (thanks to leonardyan)
* Fixing new version check not launching at startup

Co-authored-by: leonardyan <64267563+leonardyan@users.noreply.github.com>
@cdgriffith
Copy link
Owner

Have added a detection in 4.10.0 if the video is higher than 1800 pixels with HW encoder, it will automatically add that scaling for subtitles. Might need a more configurable scaling in the future, but hopefully good enough for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improve existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdgriffith @wynterca