Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New audio profiles don't work with rigaya's encoders #306

Closed
cdgriffith opened this issue Mar 11, 2022 · 5 comments
Closed

New audio profiles don't work with rigaya's encoders #306

cdgriffith opened this issue Mar 11, 2022 · 5 comments

Comments

@cdgriffith
Copy link
Owner

The new style of audio matching always creates new tracks for best behavioral results. However currently it's not possible to duplicate audio tracks with rigaya's encoders so there will be an error message.

Need to figure out the best way to use some form of advanced matching but still using the original audio inputs.

@wynterca
Copy link

wynterca commented Mar 11, 2022 via email

cdgriffith added a commit that referenced this issue Jul 21, 2022
* Adding AVIF support using libsvtav1
* Adding #352 default output directory to settings panel (thanks to Maddie Davis)
* Adding #306 support for audio profiles with pattern matching for rigaya's hardware encoders
* Adding #301 Select All feature for subtitles (thanks to ProFire and Genine-Collin)
* Adding #325 build for Ubuntu 22.04 (thanks to mrjayviper)
* Adding build for MacOS 12
* Adding #322 warning if profile audio match doesn't match anything (thanks to wynterca)
* Adding presumption that 4.x branch is last to support Windows 7 and 8 for update checks
* Fixing #319 no longer disables built in tracks for profile matching (thanks to Owen Quinlan)
* Fixing #218 and #308 subtitle scaling with rigaya's hardware encoders needs to be scaled for 4K content (thanks to wynterca)
* Fixing #350 subtitle burn in quoting (thanks to Maddie Davis)
* Fixing #346 preserve the order of audio tracks when editing a queued job (thanks to Patrick Bassner)
* Fixing #187 closing the main app while a progress bar is active will now stop that task (thanks to Todd Wilkinson)
* Fixing Chinese translations (thanks to leonardyan)
* Fixing new version check not launching at startup

Co-authored-by: leonardyan <64267563+leonardyan@users.noreply.github.com>
@cdgriffith
Copy link
Owner Author

@Wontell
Copy link

Wontell commented Sep 15, 2022

Doesnt work, only selects one track, the previous version do work, it creates 2 duplicate tracks and they work fine
This new version doesnt create duplicate tracks and does nothing
When i have 2 tracks for example, say english and russian, I always get engliish track one and russian disbaled, no matter the settings i choose in profile
Matching by Title name = doesnt work
Matching by Language = doesnt work
Matching by track number = doesnt work

@Wontell
Copy link

Wontell commented Sep 15, 2022

Look at these images
Same profile that was created with 4.10.0

Works properly on 4.9.4
p1

Doesnt work on 4.10.0
p2

@cdgriffith cdgriffith reopened this Sep 22, 2022
@cdgriffith
Copy link
Owner Author

Quick testing shows this should be fixed since 5.0.0 now, but if anyone has any more odd issues please let me know, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants