feat: graduate to stable 🚀 #287
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: github-actions <github-actions@github.com>
kaizencc
requested changes
Jan 10, 2023
README.md
Outdated
Comment on lines
2
to
10
| <!--BEGIN STABILITY BANNER--> | ||
|
|
||
| --- | ||
|
|
||
|  | ||
|
|
||
| --- | ||
|
|
||
| <!--END STABILITY BANNER--> |
There was a problem hiding this comment.
We should add this back in: showing raw and rendered verison:
<!--BEGIN STABILITY BANNER-->
---
---
<!--END STABILITY BANNER-->
| @@ -10,9 +10,8 @@ const project = new awscdk.AwsCdkConstructLibrary({ | |||
| description: 'The CDK Construct Library that helps you build ECS services using simple extensions', | |||
| name: 'cdklabs/cdk-ecs-service-extensions', | |||
| repositoryUrl: 'https://github.com/cdklabs/cdk-ecs-service-extensions.git', | |||
| stability: 'experimental', | |||
| stability: 'stable', | |||
| majorVersion: 2, | |||
There was a problem hiding this comment.
if 2.1 is the version we seek, have you confirmed this? We can enable dryRun to test it out before if we are worried.
There was a problem hiding this comment.
Yeah, let's do that to check. I don't want to accidentally re-release 2.0.0 or have a patch release go out.
There was a problem hiding this comment.
Do you mean publishDryRun in the .projenrc.js settings?
kaizencc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the alpha prerelease annotation and sets the module to "stable."