Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: graduate to stable 🚀 #287

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: graduate to stable 🚀 #287

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0fb78c
chore: mark extensions stable and remove alpha prerelease tag
bvtujo Jan 10, 2023
f71d218
chore: self mutation
invalid-email-address Jan 10, 2023
4331a92
chore: remove stability banner from README
bvtujo Jan 10, 2023
21dd54f
chore: re-add stability banner
bvtujo Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions .projen/tasks.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions .projenrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,8 @@ const project = new awscdk.AwsCdkConstructLibrary({
description: 'The CDK Construct Library that helps you build ECS services using simple extensions',
name: 'cdklabs/cdk-ecs-service-extensions',
repositoryUrl: 'https://github.com/cdklabs/cdk-ecs-service-extensions.git',
stability: 'experimental',
stability: 'stable',
majorVersion: 2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if 2.1 is the version we seek, have you confirmed this? We can enable dryRun to test it out before if we are worried.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's do that to check. I don't want to accidentally re-release 2.0.0 or have a patch release go out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean publishDryRun in the .projenrc.js settings?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe so :).

prerelease: 'alpha',

peerDeps: [
'aws-cdk-lib',
Expand Down
9 changes: 0 additions & 9 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,4 @@
# CDK Construct library for building ECS services
<!--BEGIN STABILITY BANNER-->

---

![cdk-constructs: Experimental](https://img.shields.io/badge/cdk--constructs-experimental-important.svg?style=for-the-badge)

---

<!--END STABILITY BANNER-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add this back in: showing raw and rendered verison:

<!--BEGIN STABILITY BANNER-->

---

![cdk-constructs: Stable](https://img.shields.io/badge/cdk--constructs-stable-success.svg?style=for-the-badge)

---

<!--END STABILITY BANNER-->

cdk-constructs: Stable


This library provides a high level, extensible pattern for constructing services
deployed using Amazon ECS.
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.