feat: support nested module names #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
approved these changes
Nov 6, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 14, 2023
Reverts #1350. The Orchestration DLQ is filing with messages that have errors like: ``` {\"message\":\"Submodule aws_arch.AwsAsset not found in assembly @aws-prototyping-sdk/aws-arch@0.19.64\",\"name\":\"Error\",\"stack\":\"Error: Submodule aws_arch.AwsAsset not found in assembly @aws-prototyping-sdk/aws-arch@0.19.64\\n at _Documentation.findSubmodule ``` This is blocking the construct hub pipeline, so rolling it back. This error couldn't be reproduced in `jsii-docgen`, so the change there: https://github.com/cdklabs/jsii-docgen/pull/1190/files shouldn't be reverted at this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some packages have nested submodules. This change reverts a9f1bb1 and changes the computation of the list of submodule names. Now if we have modules called
foo.bar,foo.bar.sub1andfoo.bar.sub2, the list of submodule names will be['bar', 'bar.sub1', 'bar.sub2'].By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license