Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert support for nested submodules #1354

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

comcalvi
Copy link
Contributor

Reverts #1350. The Orchestration DLQ is filing with messages that have errors like:

{\"message\":\"Submodule aws_arch.AwsAsset not found in assembly @aws-prototyping-sdk/aws-arch@0.19.64\",\"name\":\"Error\",\"stack\":\"Error: Submodule aws_arch.AwsAsset not found in assembly @aws-prototyping-sdk/aws-arch@0.19.64\\n    at _Documentation.findSubmodule

This is blocking the construct hub pipeline, so rolling it back. This error couldn't be reproduced in jsii-docgen, so the change there: https://github.com/cdklabs/jsii-docgen/pull/1190/files shouldn't be reverted at this time.

@cdklabs-automation cdklabs-automation added this pull request to the merge queue Nov 14, 2023
Merged via the queue into main with commit f349318 Nov 14, 2023
7 checks passed
@cdklabs-automation cdklabs-automation deleted the revert-1350-otaviom/nested-submodules branch November 14, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants