Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Patient Selection #156

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

c-schuler
Copy link
Contributor

@c-schuler c-schuler commented Nov 8, 2024

Updated patient selection to be a dropdown list populated by patients in the current FHIR server

Here is a screen recording of the update:

Screen.Recording.2024-11-08.at.11.57.05.AM.mov

@c-schuler
Copy link
Contributor Author

@jmandel Another one for ya to review! Thanks in advance!

@jmandel
Copy link
Member

jmandel commented Nov 8, 2024

Thanks for this! How much trouble would it be to include the Name + DOB in the selection process?

@c-schuler
Copy link
Contributor Author

c-schuler commented Nov 8, 2024

Nice idea @jmandel !

Here is the screen recording with that feedback applied:

Screen.Recording.2024-11-08.at.12.41.22.PM.mov

@c-schuler
Copy link
Contributor Author

@jmandel Please let me know if there are any other updates you'd like to see with this PR. Trying to get this pulled in for an AMIA demo if possible.

@c-schuler
Copy link
Contributor Author

@jmandel I included a small fix for the prefetch resolution using POST logic in this PR. Hopefully that is ok. Happy to create another PR for the fix.

@jmandel jmandel merged commit 049b3fa into cds-hooks:master Nov 18, 2024
@jmandel
Copy link
Member

jmandel commented Nov 18, 2024

This is merged but note that it is not yet deployed @c-schuler because the build failed at

> cds-hooks-sandbox@0.1.0 lint /home/runner/work/sandbox/sandbox
> eslint --ext .js,.jsx ./src --fix


/home/runner/work/sandbox/sandbox/src/components/PatientSelect/patient-select.jsx
Error:   41:3   error  Prop type "array" is forbidden         react/forbid-prop-types
Error:   56:49  error  'inputName' is defined but never used  no-unused-vars

/home/runner/work/sandbox/sandbox/src/retrieve-data-helpers/all-patient-retrieval.js
Error:   24:9  error  iterators/generators require regenerator-runtime, which is too heavyweight for this guide to allow them. Separately, loops should be avoided in favor of array iterations  no-restricted-syntax

@c-schuler
Copy link
Contributor Author

Understood. Applying resolution in #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants