Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link variant prop name #363

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

melaniebmn
Copy link
Collaborator

Summary | Résumé

Rename link-variant prop to variant to be consistent with other components.

Copy link
Collaborator

@daine daine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melaniebmn melaniebmn merged commit ab0e404 into develop Dec 21, 2023
3 checks passed
@melaniebmn melaniebmn deleted the correct-link-variant-prop branch December 21, 2023 19:01
@daine daine mentioned this pull request Jan 9, 2024
daine added a commit that referenced this pull request Jan 10, 2024
# Summary | Résumé

## Release v0.18.0

### New features

- Grid functionality
- Ability to add individually sized grid columns to grids as well as
allowing to set equal height rows.


### Minor

- #358 -
[34b392d](34b392d)
- Add light variant to link component

### Patch

- #363 -
[ab0e404](ab0e404)
- Link variant property name fix
- #364 -
[ee16326](ee16326)
- File uploader validation fix
- #362 -
[ac2ea8c](ac2ea8c)
- Updated Header slots in storybook
- #357 -
[5a0bd5c](5a0bd5c)
- Fixed storybook resources link
- #353 -
[e9624f0](e9624f0)
- Updated instructions for font awesome in README
This was referenced Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants