fix: File-uploader not validating properly #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
daine
added a commit
that referenced
this pull request
Jan 10, 2024
# Summary | Résumé ## Release v0.18.0 ### New features - Grid functionality - Ability to add individually sized grid columns to grids as well as allowing to set equal height rows. ### Minor - #358 - [34b392d](34b392d) - Add light variant to link component ### Patch - #363 - [ab0e404](ab0e404) - Link variant property name fix - #364 - [ee16326](ee16326) - File uploader validation fix - #362 - [ac2ea8c](ac2ea8c) - Updated Header slots in storybook - #357 - [5a0bd5c](5a0bd5c) - Fixed storybook resources link - #353 - [e9624f0](e9624f0) - Updated instructions for font awesome in README
This was referenced Jan 15, 2024
This was referenced Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Fix issue where the
gcds-file-uploaderwould prevent form submission and display an error after choosing a file when validatingonBlur. Added a small timeout to the validation inhandleChangefunction to allow the file-uploader component to re-render with the submitted file.