Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove built in wrapper for React SSR react components #535

Merged
merged 24 commits into from
Jun 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
978bac2
chore(deps): update dependency prettier to v2.8.8 (#532)
renovate[bot] May 21, 2024
b504b33
chore: Add sleep to CDN publish of angular, react and vue packages (#…
ethanWallace May 21, 2024
02b03df
chore: GCDS Components Release v0.22.0 (#526)
sre-read-write[bot] May 21, 2024
1e50d4c
fix: Remove built in wrapper for React SSR react components
ethanWallace May 22, 2024
d6204f3
refactor: update input component to increase input width calculation …
melaniebmn May 22, 2024
6c8166b
chore(docs): Update and rename CONTRIBUTING.md to CONTRIBUTION GUIDEL…
brockhigg10 May 23, 2024
c524215
fix: misaligned of FR theme and topic menu button (bug) (#541)
melaniebmn May 24, 2024
f63e3c8
docs: add fr translation for issue templates (contribution, feature r…
daine May 24, 2024
6561e4f
chore(deps): update all non-major github action dependencies (#542)
renovate[bot] May 27, 2024
81d9c55
chore(deps): update dependency prettier to v2.8.8 (#543)
renovate[bot] May 27, 2024
e9be79a
fix: change angular output install and build to be based off gcds-com…
ethanWallace May 27, 2024
e33c532
chore: GCDS Components Release v0.22.1 (#537)
sre-read-write[bot] May 27, 2024
f2ef316
chore: synced file(s) with cds-snc/site-reliability-engineering (#545)
sre-read-write[bot] May 28, 2024
17c9d7b
chore(storybook): card property typos in Storybook (#544)
ethanWallace May 28, 2024
bd1dc23
Update tsx version in react-ssr package
ethanWallace May 28, 2024
487d676
chore(storybook): add custom copy code button to storybook code previ…
melaniebmn May 28, 2024
fd4f495
ci: easier way to run storybook from root (#547)
daine May 28, 2024
a37f279
chore(deps): update dependency @angular/core to v10 [security] (#531)
renovate[bot] May 28, 2024
9428deb
Change native props rendering
ethanWallace May 30, 2024
0a70123
chore(storybook): Stop copy buttons rendering more than once (#550)
ethanWallace May 30, 2024
6445997
Add React.HTMLAttributes<HTMLElement> to types
ethanWallace May 31, 2024
29a9064
Merge branch 'main' into fix/react-ssr-wrapper
daine Jun 3, 2024
0f95a87
Update nx dependency
ethanWallace Jun 5, 2024
3c8b282
Fix hydration issues with boolean attributes
ethanWallace Jun 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 47 additions & 21 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -1,59 +1,85 @@
name: 🐛 Bug Report
description: Create a report to help us improve GC Design System
name: 🐛 Bug Report | Rapport de bogue
description: Create a report to help us improve GC Design System | Remplissez un rapport de bogue pour nous aider à améliorer Système de design GC.
title: 'bug: '
body:
- type: checkboxes
attributes:
label: Prerequisites
description: Please ensure you have completed all of the following.
label: Prerequisites | Prérequis
description: |
Please ensure you have completed all of the following.
Assurez-vous de respecter les mesures suivantes.
options:
- label: I have read the [Contributing Guidelines](https://github.com/cds-snc/gcds-components/blob/main/CONTRIBUTING.md).
- label: I have read the [Contributing Guidelines](https://github.com/cds-snc/gcds-components/blob/main/CONTRIBUTING.md). | J’ai lu les [Lignes directrices sur les contributions](https://github.com/cds-snc/gcds-components/blob/main/CONTRIBUTING.md).
required: true
- label: I agree to follow the [Code of Conduct](https://github.com/cds-snc/gcds-components/blob/main/CODE_OF_CONDUCT.md).
- label: I agree to follow the [Code of Conduct](https://github.com/cds-snc/gcds-components/blob/main/CODE_OF_CONDUCT.md). | J’accepte de me conformer au [Code de conduite](https://github.com/cds-snc/gcds-components/blob/main/CODE_OF_CONDUCT.md).
required: true
- label: I have searched for [existing issues](https://github.com/cds-snc/gcds-components/issues) that already report this problem, without success.
- label: I have searched for [existing issues](https://github.com/cds-snc/gcds-components/issues) that already report this problem, without success. | J’ai vérifié parmi [les tickets (issues) existants](https://github.com/cds-snc/gcds-components/issues) que ce sujet n’avait pas déjà été soumis.
required: true
- type: input
attributes:
label: GC Design System Components Package and Version
description: "The version number of GC Design System Components where the issue is occurring. Example: gcds-components@x.x.x, gcds-components-react@x.x.x, gcds-components-angular@x.x.x. If the issue exists in figma, please type in 'figma'"
label: GC Design System Components Package and Version | Paquet et version des composants de Système de design GC
description: |
The version number of GC Design System Components where the issue is occurring. Example: gcds-components@x.x.x, gcds-components-react@x.x.x, gcds-components-angular@x.x.x. If the issue exists in figma, please type in 'figma'.

Numéro de version des composants de Système de design GC où vous rencontrez le problème. Exemple : gcds-components@x.x.x, gcds-components-react@x.x.x, gcds-components-angular@x.x.x. Si le problème se trouve dans Figma, écrivez « Figma ».
validations:
required: true
- type: textarea
attributes:
label: Current Behavior
description: A clear description of what the bug is and how it manifests. Please provide screenshots as necessary.
label: Current Behavior | Comportement observé
description: |
A clear description of what the bug is and how it manifests. Please provide screenshots as necessary.

Une description claire du bogue et de la façon dont il se manifeste. Ajoutez des captures d’écran si nécessaire.
validations:
required: true
- type: textarea
attributes:
label: Expected Behavior
description: A clear description of what you expected to happen.
label: Expected Behavior | Comportement attendu
description: |
A clear description of what you expected to happen.

Une description claire de ce qui devrait se produire selon vous.
validations:
required: true
- type: textarea
attributes:
label: System Info
label: System Info | Information sur le système
description: |
Please provide any additional information, such as npm version, browser(s), frameworks, and version(s) as well
Please provide any additional information, such as npm version, browser(s), frameworks, and version(s) as well.

Ajoutez des renseignements additionnels comme la version npm, le navigateur, l’infrastructure et sa version.

render: shell
placeholder: System, Environment, Browsers. At minimum, tell us if you are using a framework and what version.
placeholder: |
System, Environment, Browsers. At minimum, tell us if you are using a framework and what version.

Système, environnement, navigateurs. Au minimum, dites-nous si vous utilisez une infrastructure et si oui, indiquez sa version.
- type: textarea
attributes:
label: Steps to Reproduce
description: Please explain the steps required to duplicate this issue.
label: Steps to Reproduce | Étapes pour reproduire le bogue
description: |
Please explain the steps required to duplicate this issue.

Expliquez les étapes permettant de reproduire le problème.
validations:
required: true
- type: input
attributes:
label: Code Reproduction URL
label: "Code Reproduction URL | URL de reproduction du code"
description: |
Please reproduce this issue in a blank environment and provide a link to the repo. You may use https://stackblitz.com/ or https://codesandbox.io/ to create a reproduction.
This is the best way to ensure this issue is triaged quickly.

Reproduisez le problème dans un environnement vierge et fournissez le lien du référentiel. Vous pouvez utiliser https://stackblitz.com/ ou https://codesandbox.io/ pour créer la reproduction.
C’est la meilleure façon de s’assurer que le problème est traité rapidement.
placeholder: https://github.com/...
validations:
required: false
- type: textarea
attributes:
label: Additional Information
description: List any other information that is relevant to your issue. Stack traces, related issues, suggestions on how to fix, Stack Overflow links, forum links, etc.
label: Additional Information | Informations supplémentaires
description: |
List any other information that is relevant to your issue. Stack traces, related issues, suggestions on how to fix, Stack Overflow links, forum links, etc.

Fournissez toute autre information utile. Exemple : traces d’appels (stack traces), problèmes connexes, suggestions de correctif, liens Stack Overflow, liens de forum, etc.
38 changes: 26 additions & 12 deletions .github/ISSUE_TEMPLATE/contributions.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 👷 Contribute to next priorities
description: Help us with our work on our next priorities
name: 👷 Contribute to next priorities | Contribuer aux prochaines priorités
description: Help us with our work on our next priorities | Participez à nos travaux sur nos prochaines priorités.
title: 'contribution: '
body:
- type: markdown
Expand All @@ -13,28 +13,42 @@ body:
- **examples of designs**: screenshots, prototypes, links to live services
- **research findings**: tell or show us your discovery, your use case, or how your relevant prototype or service has been tested with people using the service
- **code**: prototype code or production code; share your implementations of the relevant component or pattern in services
- type: markdown
attributes:
value: "## Merci de participer à notre projet!"
- type: markdown
attributes:
value: |
- Avant que nous entamions le développement de ces composants ou configurations, nous souhaitons nous assurer que la communauté du GC a eu l’occasion de soumettre des contributions qui peuvent éclairer et accélérer la conception et le développement.
- Voici les types de contributions que nous recherchons :
- **Exemples de designs** : captures d’écran, prototypes, liens vers des services en ligne.
- **Résultats de recherche** : recherches exploratoires, exemple de cas d’utilisation ou tests d’utilisabilité d’un prototype ou d’un service.
- **Code** : code de prototype ou de production, ou implémentations du produit.

- type: checkboxes
attributes:
label: Prerequisites
description: Complete all of the following.
label: Prerequisites | Prérequis
description: |
Complete all of the following.
Assurez-vous de respecter les mesures suivantes.
options:
- label: I've read the [Contributing Guidelines](https://github.com/cds-snc/gcds-components/blob/main/CONTRIBUTING.md).
- label: I've read the [Contributing Guidelines](https://github.com/cds-snc/gcds-components/blob/main/CONTRIBUTING.md). | J’ai lu les [Lignes directrices sur les contributions](https://github.com/cds-snc/gcds-components/blob/main/CONTRIBUTING.md)
required: true
- label: I agree to follow the [Code of Conduct](https://github.com/cds-snc/gcds-components/blob/main/CODE_OF_CONDUCT.md).
- label: I agree to follow the [Code of Conduct](https://github.com/cds-snc/gcds-components/blob/main/CODE_OF_CONDUCT.md). | J’accepte de me conformer au [Code de conduite](https://github.com/cds-snc/gcds-components/blob/main/CODE_OF_CONDUCT.md).
required: true
- type: dropdown
id: contribution-type
attributes:
label: Which component or pattern is this contribution for?
label: Which component or pattern is this contribution for? | Quel composant ou quelle configuration cette contribution vise-t-elle?
options:
- Data Table
- Image
- Tags
- Data Table | Tableau de données
- Image | Image
- Tags | Étiquettes
validations:
required: true
- type: textarea
attributes:
label: Describe your contribution.
description: Attach screenshots, or a detailed description of your contribution.
label: Describe your contribution. | Décrivez votre contribution
description: Attach screenshots, or a detailed description of your contribution. | Ajoutez des captures d’écran ou des descriptions détaillées.
validations:
required: true
65 changes: 46 additions & 19 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -1,43 +1,70 @@
name: 💡 Feature Request
description: Suggest an idea for GC Design System Components
name: 💡 Feature Request | Demander une fonctionnalité
description: Suggest an idea for GC Design System Components | Suggérez une idée pour Système de design GC.
title: 'feat: '
body:
- type: checkboxes
attributes:
label: Prerequisites
description: Complete all of the following.
label: Prerequisites | Prérequis
description: |
Complete all of the following.
Assurez-vous de respecter les mesures suivantes.

options:
- label: I've read the [Contributing Guidelines](https://github.com/cds-snc/gcds-components/blob/main/CONTRIBUTING.md).
- label: I've read the [Contributing Guidelines](https://github.com/cds-snc/gcds-components/blob/main/CONTRIBUTING.md). | J’ai lu les [Lignes directrices sur les contributions](https://github.com/cds-snc/gcds-components/blob/main/CONTRIBUTING.md).
required: true
- label: I agree to follow the [Code of Conduct](https://github.com/cds-snc/gcds-components/blob/main/CODE_OF_CONDUCT.md).
- label: I agree to follow the [Code of Conduct](https://github.com/cds-snc/gcds-components/blob/main/CODE_OF_CONDUCT.md). | J’accepte de me conformer au [Code de conduite](https://github.com/cds-snc/gcds-components/blob/main/CODE_OF_CONDUCT.md).
required: true
- label: I've searched for [existing issues](https://github.com/cds-snc/gcds-components/issues) that already report this problem, without success.
- label: I've searched for [existing issues](https://github.com/cds-snc/gcds-components/issues) that already report this problem, without success. | J’ai vérifié parmi les [tickets (issues) existants](https://github.com/cds-snc/gcds-components/issues) que ce sujet n’avait pas déjà été soumis.
required: true
- type: textarea
attributes:
label: Describe the feature request.
description: A clear and concise description of what the proposed new feature does that's distinct from existing gcds-components.
label: Describe the feature request. | Décrivez la fonctionnalité demandée
description: |
A clear and concise description of what the proposed new feature does that's distinct from existing gcds-components.

Une description claire et concise de ce que la fonctionnalité proposée permet de faire, et que les composants actuels ne permettent pas.

validations:
required: true
- type: textarea
attributes:
label: Describe the use case.
description: A clear and concise use case for what problem this feature would solve for most Government of Canada services or products.
label: Describe the use case. | Décrivez les cas d’utilisation
description: |
A clear and concise use case for what problem this feature would solve for most Government of Canada services or products.

Une description claire et concise du type de problème rencontré par la plupart des services et produits du gouvernement du Canada que cette fonctionnalité résoudrait.

validations:
required: true
- type: textarea
attributes:
label: Describe the preferred solution.
description: A clear and concise description of how you want this feature to be added to gcds-components.
label: Describe the preferred solution. | Décrivez la solution souhaitée
description: |
A clear and concise description of how you want this feature to be added to gcds-components.

Une description claire et concise de la façon dont vous voudriez voir cette fonctionnalité s’intégrer aux composants de Système de design GC.

- type: textarea
attributes:
label: Describe all alternatives.
description: A clear and concise description of any alternative solutions or features you have considered.
label: Describe all alternatives. | Décrivez toutes les solutions possibles
description: |
A clear and concise description of any alternative solutions or features you have considered.

Une description claire et concise de toutes les autres solutions ou fonctionnalités que vous avez envisagées.

- type: textarea
attributes:
label: Provide related code or examples.
description: Provide some sample code and/or screenshots to illustrate the feature request with examples.
label: Provide related code or examples. | Fournissez du code ou des exemples pertinents
description: |
Provide some sample code and/or screenshots to illustrate the feature request with examples.

Fournissez des exemples de code ou des captures d’écran qui illustrent la demande de fonctionnalité.

- type: textarea
attributes:
label: Add other relevant resources.
description: Include any other information relevant to your request, like stack traces, related issues, suggestions how to implement, Stack Overflow links, forum links, etc.
label: Add other relevant resources. | Ajoutez toute autre ressource utile
description: |
Include any other information relevant to your request, like stack traces, related issues, suggestions how to implement, Stack Overflow links, forum links, etc.

Ajoutez toute autre information utile à votre demande. Exemple : traces d’appels (stack traces), problèmes connexes, suggestions d’implémentation, liens Stack Overflow, liens de forum, etc.

8 changes: 4 additions & 4 deletions .github/workflows/build-components.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Git Checkout
uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6

- uses: actions/setup-node@c2ac33f2c62f978d6c944d9648125a294e56dc0b
- uses: actions/setup-node@eff380dfbcf941bf8832e4acb788cebe13dfd758
with:
node-version: 18

Expand All @@ -29,9 +29,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Git Checkout
uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6

- uses: actions/setup-node@c2ac33f2c62f978d6c944d9648125a294e56dc0b
- uses: actions/setup-node@eff380dfbcf941bf8832e4acb788cebe13dfd758
with:
node-version: 18

Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/compile-and-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ jobs:

steps:
- name: Git Checkout
uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6

- name: Setup Node
uses: actions/setup-node@c2ac33f2c62f978d6c944d9648125a294e56dc0b
uses: actions/setup-node@eff380dfbcf941bf8832e4acb788cebe13dfd758
with:
node-version: 18

Expand Down Expand Up @@ -113,10 +113,10 @@ jobs:

steps:
- name: Git Checkout
uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6

- name: Setup Node
uses: actions/setup-node@c2ac33f2c62f978d6c944d9648125a294e56dc0b
uses: actions/setup-node@eff380dfbcf941bf8832e4acb788cebe13dfd758
with:
node-version: 18

Expand Down Expand Up @@ -146,6 +146,7 @@ jobs:
run: |
PUBLISHED_PACKAGE="${{ steps.publish.outputs.id }}"
mkdir -p ./tmp \
&& sleep 60 \
&& npm install --prefix ./tmp "$PUBLISHED_PACKAGE" \
&& cd ./tmp/node_modules

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/export_github_data.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
DNS_PROXY_FORWARDTOSENTINEL: "true"
DNS_PROXY_LOGANALYTICSWORKSPACEID: ${{ secrets.LOG_ANALYTICS_WORKSPACE_ID }}
DNS_PROXY_LOGANALYTICSSHAREDKEY: ${{ secrets.LOG_ANALYTICS_WORKSPACE_KEY }}
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
- name: Export Data
uses: cds-snc/github-repository-metadata-exporter@main
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ossf-scorecard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ jobs:

steps:
- name: "Checkout code"
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
with:
persist-credentials: false

- name: "Run analysis"
uses: ossf/scorecard-action@50aaf84fb1a9f22255cb8bfb1729f4dd085c838c
uses: ossf/scorecard-action@c64f0a7231aa68a6849c2b65bf16af3daa23d3e6
with:
results_file: ossf-results.json
results_format: json
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-storybook.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Git Checkout
uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6

- uses: actions/setup-node@c2ac33f2c62f978d6c944d9648125a294e56dc0b
- uses: actions/setup-node@eff380dfbcf941bf8832e4acb788cebe13dfd758
with:
node-version: 18

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-generator.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
app-id: ${{ secrets.SRE_APP_ID }}
private-key: ${{ secrets.SRE_APP_PRIVATE_KEY }}

- uses: google-github-actions/release-please-action@a37ac6e4f6449ce8b3f7607e4d97d0146028dc0b # v4.1.0
- uses: google-github-actions/release-please-action@e4dc86ba9405554aeba3c6bb2d169500e7d3b4ee # v4.1.1
id: release
with:
token: ${{ steps.sre_app_token.outputs.token }}
Loading