-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove built in wrapper for React SSR react components #535
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore: GCDS Components Release * chore: update lerna and changelog * Fix typo --------- Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com> Co-authored-by: Ethan Wallace <ethan.wallace.91@gmail.com>
…536) refactor: update input component to increase input width calculation + remove max-length
…INES.md (#538) * Update and rename CONTRIBUTING.md to CONTRIBUTION GUIDELINES.md Updating contribution guidelines content in both English and French * Rename CONTRIBUTION GUIDELINES.md to CONTRIBUTING * Rename CONTRIBUTING to CONTRIBUTING.md
fix: misaligned of FR theme and topic menu button
…equest and bug report) (#533) * docs: add fr translation for issue templates (contribution) * chore: update translated template for bug reports * docs: update formatting * chore: add feature request issue template french translations * removing extra quotation mark Co-authored-by: Élise Cossette <45772213+EliseKa@users.noreply.github.com> * removing extra quotation mark Co-authored-by: Élise Cossette <45772213+EliseKa@users.noreply.github.com> --------- Co-authored-by: Élise Cossette <45772213+EliseKa@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore: GCDS Components Release * Update CHANGELOG.md * chore: update lerna version + changelog --------- Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com> Co-authored-by: Melanie Boeckmann <melanie.bockmann@gmail.com>
* chore: synced local '.github/workflows/s3-backup.yml' with remote 'tools/sre_file_sync/s3-backup.yml' * chore: synced local '.github/workflows/export_github_data.yml' with remote 'tools/sre_file_sync/export_github_data.yml' * chore: synced local '.github/workflows/ossf-scorecard.yml' with remote 'tools/sre_file_sync/ossf-scorecard.yml' --------- Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com>
fix: card property typos in Storybook
@daine Finally figured out why the build was not working in our workflows, should be good to review now. |
…ew (#540) * chore(storybook): add custom copy code button to storybook code preview * wip * damn you button haha * add min-width to copy button * revert button copy after 1.5 seconds
* chore(deps): update dependency @angular/core to v10 [security] * chore: Update angular dependencies --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ethan Wallace <ethan.wallace.91@gmail.com>
Thanks for this work @ethanWallace 🌟 Just a few things I've run into:
./app/components/layout/Header.tsx:81:43
Type error: Type '{ children: Element[]; href: string; slot: string; className: string; }' is not assignable to type 'IntrinsicAttributes & Partial<EnumsToStringLiterals<GcdsLink> & { slot: string; } & GlobalEventHandlers & { ...; }> & { ...; } & RefAttributes<...>'.
Property 'className' does not exist on type 'IntrinsicAttributes & Partial<EnumsToStringLiterals<GcdsLink> & { slot: string; } & GlobalEventHandlers & { ...; }> & { ...; } & RefAttributes<...>'.
> 81 | <GcdsLink href="/" slot="signature" className="d-flex align-items-center link-default">
| |
@daine the |
chore(storybook): Stop copy buttons rendering more than once in storybook
@daine I think it should be good for review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I checked a few things and I think this PR is good to merge in!
- I'm able to use my own component within a Gcds component (i.e. custom
PhaseBanner
insideGcdsHeader
- I can use the
className
with a Gcds component now - No longer getting the
attribute error
for boolean props (i.e.current
on nav links) - It's not part of this, but in my nextjs integration example PR I've now updated all the form components to use
GcdsWrapper
and it works well when I click on "view source" to show the rendered HTML with declarative shadow dom
LGTM!
Summary | Résumé
Remove built in
GcdsWrapper
from react components provided from@cdssnc/gcds-components-react-ssr
to allow more flexible rendering. TheGcdsWrapper
will now have to be imported along with the components. Also solves issue with usingclassName
on the react components.Usage
Example of how to use the
GcdsWrapper
with the GC Design System components