Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update input component to increase input width calculation #536

Merged
merged 1 commit into from
May 22, 2024

Conversation

melaniebmn
Copy link
Collaborator

Summary | Résumé

Update input component:

  • Increase input width calculation (2x)
  • Remove maxLength

Zenhub ticket

Copy link
Collaborator

@ethanWallace ethanWallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melaniebmn melaniebmn merged commit d6204f3 into main May 22, 2024
3 checks passed
@melaniebmn melaniebmn deleted the update-input-component branch May 22, 2024 21:09
ethanWallace added a commit that referenced this pull request Jun 7, 2024
* chore(deps): update dependency prettier to v2.8.8 (#532)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: Add sleep to CDN publish of angular, react and vue packages (#530)

* chore: GCDS Components Release v0.22.0 (#526)

* chore: GCDS Components Release

* chore: update lerna and changelog

* Fix typo

---------

Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com>
Co-authored-by: Ethan Wallace <ethan.wallace.91@gmail.com>

* fix: Remove built in wrapper for React SSR react components

* refactor: update input component to increase input width calculation (#536)

refactor: update input component to increase input width calculation + remove max-length

* chore(docs): Update and rename CONTRIBUTING.md to CONTRIBUTION GUIDELINES.md (#538)

* Update and rename CONTRIBUTING.md to CONTRIBUTION GUIDELINES.md

Updating contribution guidelines content in both English and French

* Rename CONTRIBUTION GUIDELINES.md to CONTRIBUTING

* Rename CONTRIBUTING to CONTRIBUTING.md

* fix: misaligned of FR theme and topic menu button (bug) (#541)

fix: misaligned of FR theme and topic menu button

* docs: add fr translation for issue templates (contribution, feature request and bug report) (#533)

* docs: add fr translation for issue templates (contribution)

* chore: update translated template for bug reports

* docs: update formatting

* chore: add feature request issue template french translations

* removing extra quotation mark

Co-authored-by: Élise Cossette <45772213+EliseKa@users.noreply.github.com>

* removing extra quotation mark

Co-authored-by: Élise Cossette <45772213+EliseKa@users.noreply.github.com>

---------

Co-authored-by: Élise Cossette <45772213+EliseKa@users.noreply.github.com>

* chore(deps): update all non-major github action dependencies (#542)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency prettier to v2.8.8 (#543)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix: change angular output install and build to be based off gcds-components package

* chore: GCDS Components Release v0.22.1 (#537)

* chore: GCDS Components Release

* Update CHANGELOG.md

* chore: update lerna version + changelog

---------

Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com>
Co-authored-by: Melanie Boeckmann <melanie.bockmann@gmail.com>

* chore: synced file(s) with cds-snc/site-reliability-engineering (#545)

* chore: synced local '.github/workflows/s3-backup.yml' with remote 'tools/sre_file_sync/s3-backup.yml'

* chore: synced local '.github/workflows/export_github_data.yml' with remote 'tools/sre_file_sync/export_github_data.yml'

* chore: synced local '.github/workflows/ossf-scorecard.yml' with remote 'tools/sre_file_sync/ossf-scorecard.yml'

---------

Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com>

* chore(storybook): card property typos in Storybook (#544)

fix: card property typos in Storybook

* Update tsx version in react-ssr package

* chore(storybook): add custom copy code button to storybook code preview (#540)

* chore(storybook): add custom copy code button to storybook code preview

* wip

* damn you button haha

* add min-width to copy button

* revert button copy after 1.5 seconds

* ci: easier way to run storybook from root (#547)

* chore(deps): update dependency @angular/core to v10 [security] (#531)

* chore(deps): update dependency @angular/core to v10 [security]

* chore: Update angular dependencies

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ethan Wallace <ethan.wallace.91@gmail.com>

* Change native props rendering

* chore(storybook): Stop copy buttons rendering more than once  (#550)

chore(storybook): Stop copy buttons rendering more than once in storybook

* Add React.HTMLAttributes<HTMLElement> to types

* Update nx dependency

* Fix hydration issues with boolean attributes

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com>
Co-authored-by: Melanie Boeckmann <melanie.bockmann@gmail.com>
Co-authored-by: Brock Higgins <47530176+brockhigg10@users.noreply.github.com>
Co-authored-by: Daine Trinidad <daine.trinidad@cds-snc.ca>
Co-authored-by: Élise Cossette <45772213+EliseKa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants