Added some useful methods and docs #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Eline <aeline+github@amazon.com>
2 tasks
aaronjeline
force-pushed
the
1184-some-usability-improvements
branch
from
47f507f to
f759fef
Compare
john-h-kastner-aws
approved these changes
Sep 10, 2024
cedar-policy/src/api.rs
Outdated
| @@ -345,6 +356,10 @@ impl Entities { | |||
| /// error if attributes have the wrong types (e.g., string instead of | |||
| /// integer), or if required attributes are missing or superfluous | |||
| /// attributes are provided. | |||
| /// # Errors | |||
There was a problem hiding this comment.
We could consider enabling the missing_error_doc lint if we believe this sort of documentation is valuable.
cdisselkoen
reviewed
Sep 10, 2024
Co-authored-by: John Kastner <130772734+john-h-kastner-aws@users.noreply.github.com> Co-authored-by: Craig Disselkoen <cdiss@amazon.com> Signed-off-by: Aaron Eline <aeline+github@amazon.com>
aaronjeline
force-pushed
the
1184-some-usability-improvements
branch
from
e1058bf to
f6b153e
Compare
cdisselkoen
approved these changes
Sep 10, 2024
aaronjeline
added a commit
that referenced
this pull request
Sep 10, 2024
Signed-off-by: Aaron Eline <aeline+github@amazon.com> Co-authored-by: John Kastner <130772734+john-h-kastner-aws@users.noreply.github.com> Co-authored-by: Craig Disselkoen <cdiss@amazon.com>
This was referenced Sep 10, 2024
khieta
pushed a commit
that referenced
this pull request
Sep 10, 2024
Signed-off-by: Aaron Eline <aeline+github@amazon.com> Co-authored-by: John Kastner <130772734+john-h-kastner-aws@users.noreply.github.com> Co-authored-by: Craig Disselkoen <cdiss@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Entity::new_without_attrsthat can't errorEntityis nowHash, which is very useful as we require that entity collections lack duplicatesEntitiesclarifying when errors are returnedIssue #, if available
#1184
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., addition of a new API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):