Entity slicing with manifest #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: oflatt <oflatt@gmail.com> fix up after rebase Signed-off-by: oflatt <oflatt@gmail.com> more bad rebase cleanup Signed-off-by: oflatt <oflatt@gmail.com> more small cleanup Signed-off-by: oflatt <oflatt@gmail.com> some cleanup Signed-off-by: oflatt <oflatt@gmail.com> separate entity slicing from manifest file Signed-off-by: oflatt <oflatt@gmail.com> remove simple entity loader for now Signed-off-by: oflatt <oflatt@gmail.com> exhaustive Signed-off-by: oflatt <oflatt@gmail.com> fix up testing infra with feature flag Signed-off-by: oflatt <oflatt@gmail.com> nits Signed-off-by: oflatt <oflatt@gmail.com> fix up should panic Signed-off-by: oflatt <oflatt@gmail.com> remove use of panic from testing infra Signed-off-by: oflatt <oflatt@gmail.com> nits Signed-off-by: oflatt <oflatt@gmail.com> entity manifest cfg Signed-off-by: oflatt <oflatt@gmail.com> make errors more reusable Signed-off-by: oflatt <oflatt@gmail.com> revert cedar testing changes Signed-off-by: oflatt <oflatt@gmail.com> fmt Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
…tated' into feature/entity-slicing-with-manifest
…to feature/entity-slicing-with-manifest
shaobo-he-aws
changed the title
|
What's the plan on making it compatible with entity tags? |
…g-with-manifest Signed-off-by: Shaobo He <shaobohe@amazon.com>
Entity tags has been a released feature. So, we will temporary make entity manifest error on policies using entity tags. |
shaobo-he-aws
requested review from
cdisselkoen,
john-h-kastner-aws,
adpaco-aws and
andrewmwells-amazon
and removed request for
cdisselkoen
andrewmwells-amazon
approved these changes
Nov 12, 2024
Co-authored-by: Andrew Wells <130512013+andrewmwells-amazon@users.noreply.github.com>
…g-with-manifest Signed-off-by: Shaobo He <shaobohe@amazon.com>
john-h-kastner-aws
approved these changes
Nov 13, 2024
|
also, can you confirm that you've looked into the details of the SemVer Checks failure? it's presumably behind a feature flag, but we should be sure of that |
Co-authored-by: John Kastner <130772734+john-h-kastner-aws@users.noreply.github.com>
Yes. I looked into it. This PR removed an enum variant which is under the feature flag. So it should be a false alarm. |
john-h-kastner-aws
approved these changes
Nov 14, 2024
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):cedar-spec, and how you have tested that your updates are correct.)I confirm that
docs.cedarpolicy.com(choose one, and delete the other options):