Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity slicing with manifest #1239

Merged
merged 46 commits into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from 44 commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
484a00c
Entity slicing implementation
oflatt Jun 21, 2024
b4cf017
generalization almost works
oflatt Aug 1, 2024
099b0f5
tests passing yay
oflatt Aug 28, 2024
8ac3a9b
stronger testing
oflatt Aug 28, 2024
823e635
small nits
oflatt Aug 28, 2024
cd15b98
a bunch of panic safety
oflatt Aug 28, 2024
f2488fd
no need to get parents for contains
oflatt Aug 28, 2024
f3437d3
stray print
oflatt Aug 28, 2024
ed702e5
remove stray todo
oflatt Aug 28, 2024
d47b7db
fix up old import
oflatt Aug 29, 2024
f31de82
fix bug caught by fuzzing with has attr on record literals
oflatt Aug 30, 2024
14daea7
empty paths for has attr
oflatt Aug 30, 2024
53e01fe
more careful with empty paths
oflatt Aug 30, 2024
38cd4ea
oops, empty paths on hasattr
oflatt Aug 30, 2024
ec6dec9
integration testing should test entity manifest
oflatt Aug 29, 2024
04b1ea3
initial commit for ancestor tries, tests failing
oflatt Sep 3, 2024
37bc6e6
tests passing without more precise slicing
oflatt Sep 3, 2024
a5d0aa9
slicing of ancestors working and tested
oflatt Sep 3, 2024
0cc5319
fix slicing for sets of entities
oflatt Sep 3, 2024
4bd61c2
better description
oflatt Sep 6, 2024
ab19d6c
type annotations first commit: add new file for type annotations
oflatt Sep 10, 2024
5ec77c0
working on migrating to_typed
oflatt Sep 10, 2024
6219acb
working on type annotations in the structs
oflatt Sep 10, 2024
8e3129a
remove confusing comment
oflatt Sep 10, 2024
5a99855
optional types
oflatt Sep 10, 2024
8fb8625
from json function
oflatt Sep 10, 2024
ff64d4a
progress on error messages
oflatt Sep 11, 2024
4b1f533
fix up case for has
oflatt Sep 11, 2024
d04fde0
test type annotations
oflatt Sep 11, 2024
a008766
entity loader file
oflatt Sep 11, 2024
e39124c
implement entity loader api, untested
oflatt Sep 13, 2024
0407a10
tests passing with new entity loader, ancestors a bit ugly
oflatt Sep 16, 2024
9b018bf
clean up ancestor loading somewhat
oflatt Sep 16, 2024
b380488
database consistency warning
oflatt Sep 16, 2024
16b0085
Merge remote-tracking branch 'origin/oflatt/entity-manifest-type-anno…
shaobo-he-aws Sep 27, 2024
26b9a1e
Merge remote-tracking branch 'origin/oflatt/entity-slicing-loader' in…
shaobo-he-aws Sep 27, 2024
6365c76
Merge remote-tracking branch 'origin/main' into feature/entity-slicin…
shaobo-he-aws Sep 27, 2024
16f4319
Merge remote-tracking branch 'origin/main' into feature/entity-slicin…
shaobo-he-aws Nov 7, 2024
cfc2ba6
minor fix
shaobo-he-aws Nov 7, 2024
aba6297
restructure code
shaobo-he-aws Nov 8, 2024
664144b
refactor
shaobo-he-aws Nov 8, 2024
3039e10
updates
shaobo-he-aws Nov 8, 2024
b980246
Apply suggestions from code review
shaobo-he-aws Nov 12, 2024
3f2f23e
Merge remote-tracking branch 'origin/main' into feature/entity-slicin…
shaobo-he-aws Nov 13, 2024
1af6aaf
Apply suggestions from code review
shaobo-he-aws Nov 13, 2024
a631fc1
use #""#
shaobo-he-aws Nov 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions cedar-policy-core/src/ast/entity.rs
Original file line number Diff line number Diff line change
Expand Up @@ -569,14 +569,7 @@ impl Entity {
Ok(())
}

/// Mark the given `UID` as an ancestor of this `Entity`.
// When fuzzing, `add_ancestor()` is fully `pub`.
#[cfg(not(fuzzing))]
pub(crate) fn add_ancestor(&mut self, uid: EntityUID) {
self.ancestors.insert(uid);
}
/// Mark the given `UID` as an ancestor of this `Entity`
#[cfg(fuzzing)]
pub fn add_ancestor(&mut self, uid: EntityUID) {
self.ancestors.insert(uid);
}
Expand Down
Loading
Loading