Xcode7 Support #354
Xcode7 Support #354
Conversation
Leaving the old hacks for Xcode 6 since the XCTestObservation protocol was previously deprecated, behaved differently then, and the observation center had not been introduced then.
Shoutout to @jeffh for catching these.
We should revert / rewrite history before this branch is merged into master. This is purely for our convenience when running tests against the xcode 7 betas.
This allows us to run the same tasks, regardless of which xcode version is available and currently selected.
We discovered today that building specs with Xcode 7 introduces a different 0 indexed dyld image compared to previous versions. Starting in Xcode 7 the image is something like /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk/usr/lib/dyld_sim (or Xcode-beta) Where in previous versions it would be the path to the application that was going to be run (e.g.: either your specs app, or the production app in the case of test bundles).
Long live XCTest
Also delete the OS X Failing Test Bundle because recent Xcode versions make it nearly impossible to link a test bundle without XCTest
|
Thanks so much for taking the time to clean this up and make this easier to maintain, @briancroom! This looks great. |
|
@briancroom This is merged into master now - is xcode7 branch still relevant or should we use master for xcode 7 builds? |
|
Deleting that branch will cause anyone using it to realize that something that changed, so it seems reasonable to delete it so no one continues to rely on it. I'm for deleting it. |
|
@briancroom @tjarratt Do you know when PivotalCoreKit will update to the XCode 7 version of Cedar? |
|
@adamhrz There is a PR open at pivotal-legacy/PivotalCoreKit#156 which I need to revisit and update a bit now that the Cedar's Xcode 7 work has been merged. |
|
@briancroom thanks for the update. Do you think we're looking at 2 weeks, a month or longer as a timeframe? Trying to plan our own migration and since we use Cedar and Pivotal we're trying to decide if it's worth a local patch in the short term |
|
I'm thinking it shouldn't be too long - definitely within 2 weeks unless unforeseen difficulties arise. |
Hey folks, the time has come to finally see about getting this merged into master. I have rebased this as a new branch because I managed to botch merging master into the long-lived Xcode7 branch a while back, and didn't want to deal with figuring out how to resolve that mess.
In addition to the great work that @tjarratt and pairs did over the course of the summer to get the Xcode 7 support bootstrapped and to fix some of the symbolication issues, I have now done a bunch of additional cleanup to try to get things in good shape. This includes:
atostoolAt this point,
rakepasses on my workstation when building with Xcode 7 GM, and Travis should be passing, although it is not using Xcode 7 yet. There are some extra issues related to the Travis build being discussed at #345.Please give it a whirl and let me know if there are any critical issues that would prevent us from getting this merged in!
(Pinging some people who have been involved in the discussion at #333: @akitchen @tjarratt @alexbasson @joemasilotti @mjstallard)