Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

Cedar support? #417

Closed
haskelash opened this issue Sep 5, 2014 · 17 comments
Closed

Cedar support? #417

haskelash opened this issue Sep 5, 2014 · 17 comments

Comments

@haskelash
Copy link

I'm trying to get our project to work with Travis CI which uses xctool. Our project uses Cedar as a testing framework. On Travis, our project builds fine and everything is green, but it doesn't actually run the tests. It says "** TEST SUCCEEDED: 0 passed, 0 failed, 0 errored, 0 total **"

I also get this warning

skipping: This test bundle contained no tests.

Is there a way to get Cedar working with xctool/Travis?

Thanks.

@LegNeato
Copy link
Contributor

LegNeato commented Sep 9, 2014

Hmmm, the Cedar team's travis build seems to use the stock (xctool) build and test. We don't use it at FB though so can't confirm for sure.

@LegNeato
Copy link
Contributor

LegNeato commented Sep 9, 2014

The logic for that is here:

https://github.com/facebook/xctool/blob/master/xctool/xctool/RunTestsAction.m#L559

Perhaps we are keying off something that doesn't hold with Cedar? Mind reproing and debugging a bit?

@ExtremeMan
Copy link
Contributor

@jonstorer
Copy link

Any movement on this? I'd love to use xctool on travis, but without Cedar support, it's impossible.

@ExtremeMan
Copy link
Contributor

We will be happy to review PR. Though I don't think we will add it by our own in the nearest future.

@ghost
Copy link

ghost commented Aug 5, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

@adamhrz
Copy link

adamhrz commented Sep 30, 2015

@haskelash There is a new version of Cedar that works on XCode 7. We were seeing the 0 tests and turned out to be Cedar and PivotalCoreKit which were both updated September 16th cedarbdd/cedar#354

@ExtremeMan
Copy link
Contributor

@adamhrz, ah, awesome. Could you just double confirm that xctool + Xcode 7 + Cedar are working together? If yes, I will close the issue then.

@adamhrz
Copy link

adamhrz commented Sep 30, 2015

@ExtremeMan Just digging out my command line xctool command for this project and will confirm

@ExtremeMan
Copy link
Contributor

@adamhrz, thanks a lot. I appreciate that.

@adamhrz
Copy link

adamhrz commented Sep 30, 2015

@ExtremeMan @haskelash confirmed xctool 0.2.4 running xcode7cedar tests fails but xctool 0.2.6 running xcode7cedar tests pass

@ExtremeMan
Copy link
Contributor

Awesome, @adamhrz. Thanks a lot for looking and confirming! Closing since it is fixed.

@adamhrz
Copy link

adamhrz commented Oct 1, 2015

@ExtremeMan @haskelash My apologies but while it seemed things were running here when running from the command line (requiring xctool 0.2.6) the actual run-test phase fails because it says the .xctest folder contains no tests

@ExtremeMan
Copy link
Contributor

So you see ** TEST SUCCEEDED: 0 passed, 0 failed, 0 errored, 0 total **?

@adamhrz
Copy link

adamhrz commented Oct 1, 2015

Unfortunately, yes. Running xcodebuild works fine and generates our junit
output for reporting to CI:

xcodebuild -project "blahblahblah.xcodeproj" -scheme "blahblahblahApp" -sdk
iphonesimulator test | xcpretty -r junit --output ./junit.xml

On Thu, Oct 1, 2015 at 10:44 AM, Aleksey Kononov notifications@github.com
wrote:

So you see ** TEST SUCCEEDED: 0 passed, 0 failed, 0 errored, 0 total **?


Reply to this email directly or view it on GitHub
#417 (comment).

Adam Howitt, Senior Software Developer

Raizlabs Corporation: Mobile Strategy, Design, and Development
www.raizlabs.com | adam.howitt@raizlabs.com | @earnshavian
https://twitter.com/earnshavian

@briancroom
Copy link

Just a quick update to ensure all interested parties get notified - Cedar's behavior has been adjusted to allow xctool's otest-query to find Cedar specs, fixing this issue.

@ExtremeMan
Copy link
Contributor

Awesome, thanks for the update and fix, @briancroom !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants