feature: search by submitting form #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… form and both lists had results
cedvdb
added a commit
that referenced
this pull request
Feb 2, 2024
* Supported safe area in bottom sheet of country selector (#153) Co-authored-by: Serge Shkurko <shkurko@thekey.space> * update intl to 18.0 (#156) * 7.0.6 * Fix search cursor color and initial bottom sheet height (#157) * downgrade intl * fix cursor color * fix panel height * enlarge prefix hit area * added cursor fix * revert changes from incorrect pr * feature: allow searching by ISO code * feature: search by submitting form * bugfix: fixed issue where it would double pop the route if submitting form and both lists had results * feature: search by submitting form (#160) * feature: search by submitting form * bugfix: fixed issue where it would double pop the route if submitting form and both lists had results * feature: allow searching by ISO code (#161) * bugfix: hide the keyboard when scrolling list, so it doesn't overlap * feature: use autofill hints for search input * feature: auto-submit when autofilling/pasting country * refactor: move change handler into seperate method * refactor: fixed deprecated window usage * fix: copy/paste wasn't possible due to context menu builder being passed as null * fix: remove listener on dispose --------- Co-authored-by: Serge Shkurko <sergeshkurko@outlook.com> Co-authored-by: Serge Shkurko <shkurko@thekey.space> Co-authored-by: zitob9 <elias.housni@gmail.com> Co-authored-by: cedvdb <cedvandenbosch@gmail.com> Co-authored-by: cizmarf <37090294+cizmarf@users.noreply.github.com> Co-authored-by: Mattias Siø Fjellvang <mattias@doubble.dk>
cedvdb
added a commit
that referenced
this pull request
Feb 2, 2024
* Supported safe area in bottom sheet of country selector (#153) Co-authored-by: Serge Shkurko <shkurko@thekey.space> * update intl to 18.0 (#156) * 7.0.6 * Fix search cursor color and initial bottom sheet height (#157) * downgrade intl * fix cursor color * fix panel height * enlarge prefix hit area * added cursor fix * revert changes from incorrect pr * feature: allow searching by ISO code * feature: search by submitting form * bugfix: fixed issue where it would double pop the route if submitting form and both lists had results * feature: search by submitting form (#160) * feature: search by submitting form * bugfix: fixed issue where it would double pop the route if submitting form and both lists had results * feature: allow searching by ISO code (#161) * bugfix: hide the keyboard when scrolling list, so it doesn't overlap * feature: use autofill hints for search input * feature: auto-submit when autofilling/pasting country * refactor: move change handler into seperate method * refactor: fixed deprecated window usage * fix: copy/paste wasn't possible due to context menu builder being passed as null * fix: remove listener on dispose --------- Co-authored-by: Serge Shkurko <sergeshkurko@outlook.com> Co-authored-by: Serge Shkurko <shkurko@thekey.space> Co-authored-by: zitob9 <elias.housni@gmail.com> Co-authored-by: cedvdb <cedvandenbosch@gmail.com> Co-authored-by: cizmarf <37090294+cizmarf@users.noreply.github.com> Co-authored-by: Mattias Siø Fjellvang <mattias@doubble.dk>
cedvdb
added a commit
that referenced
this pull request
Feb 5, 2024
* fix: disable country chip when field is disabled (#202) * fix: disable country chip when field is disabled * fixup! fix: disable country chip when field is disabled * fixup! fixup! fix: disable country chip when field is disabled * add ku and ckb translations (#209) * fix: copy/paste wasn't possible due to context menu builder being passed as null (#198) Co-authored-by: Mattias Siø Fjellvang <mattias@doubble.dk> * bugfix: close keyboard on scroll (#162) * Supported safe area in bottom sheet of country selector (#153) Co-authored-by: Serge Shkurko <shkurko@thekey.space> * update intl to 18.0 (#156) * 7.0.6 * Fix search cursor color and initial bottom sheet height (#157) * downgrade intl * fix cursor color * fix panel height * enlarge prefix hit area * added cursor fix * revert changes from incorrect pr * feature: allow searching by ISO code * feature: search by submitting form * bugfix: fixed issue where it would double pop the route if submitting form and both lists had results * feature: search by submitting form (#160) * feature: search by submitting form * bugfix: fixed issue where it would double pop the route if submitting form and both lists had results * feature: allow searching by ISO code (#161) * bugfix: hide the keyboard when scrolling list, so it doesn't overlap * feature: use autofill hints for search input * feature: auto-submit when autofilling/pasting country * refactor: move change handler into seperate method * refactor: fixed deprecated window usage * fix: copy/paste wasn't possible due to context menu builder being passed as null * fix: remove listener on dispose --------- Co-authored-by: Serge Shkurko <sergeshkurko@outlook.com> Co-authored-by: Serge Shkurko <shkurko@thekey.space> Co-authored-by: zitob9 <elias.housni@gmail.com> Co-authored-by: cedvdb <cedvandenbosch@gmail.com> Co-authored-by: cizmarf <37090294+cizmarf@users.noreply.github.com> Co-authored-by: Mattias Siø Fjellvang <mattias@doubble.dk> * feature: autofill country (#163) * Supported safe area in bottom sheet of country selector (#153) Co-authored-by: Serge Shkurko <shkurko@thekey.space> * update intl to 18.0 (#156) * 7.0.6 * Fix search cursor color and initial bottom sheet height (#157) * downgrade intl * fix cursor color * fix panel height * enlarge prefix hit area * added cursor fix * revert changes from incorrect pr * feature: allow searching by ISO code * feature: search by submitting form * bugfix: fixed issue where it would double pop the route if submitting form and both lists had results * feature: search by submitting form (#160) * feature: search by submitting form * bugfix: fixed issue where it would double pop the route if submitting form and both lists had results * feature: allow searching by ISO code (#161) * bugfix: hide the keyboard when scrolling list, so it doesn't overlap * feature: use autofill hints for search input * feature: auto-submit when autofilling/pasting country * refactor: move change handler into seperate method * refactor: fixed deprecated window usage * fix: copy/paste wasn't possible due to context menu builder being passed as null * fix: remove listener on dispose --------- Co-authored-by: Serge Shkurko <sergeshkurko@outlook.com> Co-authored-by: Serge Shkurko <shkurko@thekey.space> Co-authored-by: zitob9 <elias.housni@gmail.com> Co-authored-by: cedvdb <cedvandenbosch@gmail.com> Co-authored-by: cizmarf <37090294+cizmarf@users.noreply.github.com> Co-authored-by: Mattias Siø Fjellvang <mattias@doubble.dk> * feat: add ability to customise search delegate app bar theme (#208) * Refactor (#212) * fix merge issue * remove generated files from git * saving * refactor * improve search ux * refactor * saving * refactor * rm * upgrade flag cache * cache * saving * refa * refactor * comment * validation * moving tests * saving * language * fixing tests * fix tests * saving * saving * saving * fix all tests * External country selector (#213) * fix merge issue * remove generated files from git * saving * refactor * improve search ux * refactor * saving * refactor * rm * upgrade flag cache * cache * saving * refa * refactor * comment * validation * moving tests * saving * language * fixing tests * fix tests * saving * saving * saving * fix all tests * localization * readd example * localization * dart fix * external country selector * cc --------- Co-authored-by: Tautvydas Šidlauskas <tautvydas.sidlauskas@gmail.com> Co-authored-by: Ahmad Najm <86409804+ahmadnajmdev@users.noreply.github.com> Co-authored-by: Mattias Fjellvang <simplenotezy@users.noreply.github.com> Co-authored-by: Mattias Siø Fjellvang <mattias@doubble.dk> Co-authored-by: Serge Shkurko <sergeshkurko@outlook.com> Co-authored-by: Serge Shkurko <shkurko@thekey.space> Co-authored-by: zitob9 <elias.housni@gmail.com> Co-authored-by: cizmarf <37090294+cizmarf@users.noreply.github.com>
cedvdb
added a commit
that referenced
this pull request
Feb 5, 2024
* fix: disable country chip when field is disabled (#202) * fix: disable country chip when field is disabled * fixup! fix: disable country chip when field is disabled * fixup! fixup! fix: disable country chip when field is disabled * add ku and ckb translations (#209) * fix: copy/paste wasn't possible due to context menu builder being passed as null (#198) Co-authored-by: Mattias Siø Fjellvang <mattias@doubble.dk> * bugfix: close keyboard on scroll (#162) * Supported safe area in bottom sheet of country selector (#153) Co-authored-by: Serge Shkurko <shkurko@thekey.space> * update intl to 18.0 (#156) * 7.0.6 * Fix search cursor color and initial bottom sheet height (#157) * downgrade intl * fix cursor color * fix panel height * enlarge prefix hit area * added cursor fix * revert changes from incorrect pr * feature: allow searching by ISO code * feature: search by submitting form * bugfix: fixed issue where it would double pop the route if submitting form and both lists had results * feature: search by submitting form (#160) * feature: search by submitting form * bugfix: fixed issue where it would double pop the route if submitting form and both lists had results * feature: allow searching by ISO code (#161) * bugfix: hide the keyboard when scrolling list, so it doesn't overlap * feature: use autofill hints for search input * feature: auto-submit when autofilling/pasting country * refactor: move change handler into seperate method * refactor: fixed deprecated window usage * fix: copy/paste wasn't possible due to context menu builder being passed as null * fix: remove listener on dispose --------- Co-authored-by: Serge Shkurko <sergeshkurko@outlook.com> Co-authored-by: Serge Shkurko <shkurko@thekey.space> Co-authored-by: zitob9 <elias.housni@gmail.com> Co-authored-by: cedvdb <cedvandenbosch@gmail.com> Co-authored-by: cizmarf <37090294+cizmarf@users.noreply.github.com> Co-authored-by: Mattias Siø Fjellvang <mattias@doubble.dk> * feature: autofill country (#163) * Supported safe area in bottom sheet of country selector (#153) Co-authored-by: Serge Shkurko <shkurko@thekey.space> * update intl to 18.0 (#156) * 7.0.6 * Fix search cursor color and initial bottom sheet height (#157) * downgrade intl * fix cursor color * fix panel height * enlarge prefix hit area * added cursor fix * revert changes from incorrect pr * feature: allow searching by ISO code * feature: search by submitting form * bugfix: fixed issue where it would double pop the route if submitting form and both lists had results * feature: search by submitting form (#160) * feature: search by submitting form * bugfix: fixed issue where it would double pop the route if submitting form and both lists had results * feature: allow searching by ISO code (#161) * bugfix: hide the keyboard when scrolling list, so it doesn't overlap * feature: use autofill hints for search input * feature: auto-submit when autofilling/pasting country * refactor: move change handler into seperate method * refactor: fixed deprecated window usage * fix: copy/paste wasn't possible due to context menu builder being passed as null * fix: remove listener on dispose --------- Co-authored-by: Serge Shkurko <sergeshkurko@outlook.com> Co-authored-by: Serge Shkurko <shkurko@thekey.space> Co-authored-by: zitob9 <elias.housni@gmail.com> Co-authored-by: cedvdb <cedvandenbosch@gmail.com> Co-authored-by: cizmarf <37090294+cizmarf@users.noreply.github.com> Co-authored-by: Mattias Siø Fjellvang <mattias@doubble.dk> * feat: add ability to customise search delegate app bar theme (#208) * fix merge issue * remove generated files from git * saving * refactor * improve search ux * refactor * saving * refactor * rm * upgrade flag cache * cache * saving * refa * refactor * comment * validation * moving tests * saving * language * fixing tests * fix tests * saving * saving * saving * fix all tests * Refactor (#212) * fix merge issue * remove generated files from git * saving * refactor * improve search ux * refactor * saving * refactor * rm * upgrade flag cache * cache * saving * refa * refactor * comment * validation * moving tests * saving * language * fixing tests * fix tests * saving * saving * saving * fix all tests * localization * readd example * localization * dart fix * external country selector * cc * External country selector (#213) * fix merge issue * remove generated files from git * saving * refactor * improve search ux * refactor * saving * refactor * rm * upgrade flag cache * cache * saving * refa * refactor * comment * validation * moving tests * saving * language * fixing tests * fix tests * saving * saving * saving * fix all tests * localization * readd example * localization * dart fix * external country selector * cc * dart fix * bump version * External country selector (#215) * fix merge issue * remove generated files from git * saving * refactor * improve search ux * refactor * saving * refactor * rm * upgrade flag cache * cache * saving * refa * refactor * comment * validation * moving tests * saving * language * fixing tests * fix tests * saving * saving * saving * fix all tests * localization * readd example * localization * dart fix * external country selector * cc * dart fix * bump version * mv --------- Co-authored-by: Tautvydas Šidlauskas <tautvydas.sidlauskas@gmail.com> Co-authored-by: Ahmad Najm <86409804+ahmadnajmdev@users.noreply.github.com> Co-authored-by: Mattias Fjellvang <simplenotezy@users.noreply.github.com> Co-authored-by: Mattias Siø Fjellvang <mattias@doubble.dk> Co-authored-by: Serge Shkurko <sergeshkurko@outlook.com> Co-authored-by: Serge Shkurko <shkurko@thekey.space> Co-authored-by: zitob9 <elias.housni@gmail.com> Co-authored-by: cizmarf <37090294+cizmarf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows taking the top result when pressing "OK" on the keyboard, or otherwise submitting the search input field, for a more convenient way of selecting country in the dropdown.