bugfix: close keyboard on scroll

[simplenotezy]

A minor update, that hides the keyboard when scrolling the list:

RPReplay_Final1677107102.MP4

[cedvdb]

This is a fantastic UX improvement. Thanks

[cedvdb]

This seems to be a fix for another issue

[simplenotezy]

Yup, you're right. My mistake merging it in here.

[cedvdb]

Same as for the other PR Let's add a test and remove the part that's for another PR please. This is a great addition but I have to require some test solidity for my own sanity. Will merge as soon as that's done.

[simplenotezy]

@cedvdb I don't have any experience with writing such tests in Flutter unfortunately, and very limited on time these days, would learn a lot by seeing someone else present how such a frontend test could look like.

[cedvdb]

@cedvdb I don't have any experience with writing such tests in Flutter unfortunately, and very limited on time these days, would learn a lot by seeing someone else present how such a frontend test could look like.

There are tests in the test folder. A test that verifies that when scrolling the keyboard is not shown anymore would be good.

Essentially something like the pseudo code

testWidgets('Should hide keyboard on scroll', (widgetTester) {

    await widgetTester.pumpWidget( country-selector-widget );
    await widgetTester.pumpAndSettle();

    // test that the keyboard is shown initially
    expect(tester.testTextInput.isVisible, isTrue);

    await widgetTester.scroll(...);

    await widgetTester.pumpAndSettle();
    // check that the keyboard is not shown anymore
    expect(tester.testTextInput.isVisible, isFalse);

});

[cedvdb]

note that this change seems to be for another PR.

[cedvdb]

@simplenotezy Is the comment above clear enough to go forward with the test ?