-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spack-based workflow to add all supported Geant4 versions to CI #1149
Add spack-based workflow to add all supported Geant4 versions to CI #1149
Conversation
e68a0af
to
d03cd0c
Compare
089a864
to
fe5fbe6
Compare
fe5fbe6
to
84b93f2
Compare
f273cfe
to
0a0d134
Compare
@drbenmorgan This is finally working 😅 and by working I'm including "demonstrating the existing failures of everything but Geant4@11.0". Immediately after this is merged I'll update #1152 to show that the builds are fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but just for my education, I assume this doesn't trigger a spack install
of any package (i.e. it assumes things will always be resolved in the buildcache)?
@drbenmorgan Correct, it shouldn't. I'm explicitly using the hash of the spack version and the installer fixed, and I'm even caching the concretization, so nothing should be rebuilt. The caching job is actually getting too big for the free github runners (see https://github.com/celeritas-project/spack-gha-buildcache/actions/runs/8304439200 ) so I may soon have to build the cache on a non-GHA system using docker. |
…1149) * Add note about pull requests * Show ccache stats even on failure * Add spack-based CI build * Add spack build to push/pr * Mark failing builds as experimental * Fix missing compiler/version from matrix * Use patched geant4 in upstream spack * Use only celer buildcache * Shorten padded length * Don't push the buildcache... * Load version information to fix examples
This adds a new github action for testing arbitrary combinations of dependencies, starting with all Geant4 versions. It uses a spack buildcache hosted at https://github.com/celeritas-project/spack-gha-buildcache to speed up builds. Because of build/configure/example errors, basically everything but 11.0 is failing at the moment, so I am labeling the jobs as "experimental" (allowed to fail) and will fix the relevant code in a follow-on PR (#1152).