Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spack-based workflow to add all supported Geant4 versions to CI #1149

Merged
merged 12 commits into from
Mar 18, 2024

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Mar 13, 2024

This adds a new github action for testing arbitrary combinations of dependencies, starting with all Geant4 versions. It uses a spack buildcache hosted at https://github.com/celeritas-project/spack-gha-buildcache to speed up builds. Because of build/configure/example errors, basically everything but 11.0 is failing at the moment, so I am labeling the jobs as "experimental" (allowed to fail) and will fix the relevant code in a follow-on PR (#1152).

@sethrj sethrj added documentation Documentation, examples, tests, and CI enhancement New feature or request labels Mar 13, 2024
@sethrj sethrj marked this pull request as draft March 13, 2024 16:31
@sethrj sethrj force-pushed the spack-workflow-actions branch 2 times, most recently from e68a0af to d03cd0c Compare March 13, 2024 18:17
@sethrj sethrj force-pushed the spack-workflow-actions branch from 089a864 to fe5fbe6 Compare March 15, 2024 17:29
@sethrj sethrj requested review from amandalund, drbenmorgan and pcanal and removed request for amandalund March 15, 2024 17:30
@sethrj sethrj marked this pull request as ready for review March 15, 2024 17:30
@sethrj sethrj force-pushed the spack-workflow-actions branch from fe5fbe6 to 84b93f2 Compare March 15, 2024 17:39
@sethrj sethrj force-pushed the spack-workflow-actions branch from f273cfe to 0a0d134 Compare March 15, 2024 18:17
@sethrj
Copy link
Member Author

sethrj commented Mar 17, 2024

@drbenmorgan This is finally working 😅 and by working I'm including "demonstrating the existing failures of everything but Geant4@11.0". Immediately after this is merged I'll update #1152 to show that the builds are fixed.

Copy link
Contributor

@drbenmorgan drbenmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but just for my education, I assume this doesn't trigger a spack install of any package (i.e. it assumes things will always be resolved in the buildcache)?

@sethrj
Copy link
Member Author

sethrj commented Mar 18, 2024

@drbenmorgan Correct, it shouldn't. I'm explicitly using the hash of the spack version and the installer fixed, and I'm even caching the concretization, so nothing should be rebuilt. The caching job is actually getting too big for the free github runners (see https://github.com/celeritas-project/spack-gha-buildcache/actions/runs/8304439200 ) so I may soon have to build the cache on a non-GHA system using docker.

@sethrj sethrj enabled auto-merge (squash) March 18, 2024 15:05
@sethrj sethrj merged commit 63821fb into celeritas-project:develop Mar 18, 2024
21 of 27 checks passed
@sethrj sethrj deleted the spack-workflow-actions branch March 18, 2024 15:24
sethrj added a commit that referenced this pull request Mar 18, 2024
…1149)

* Add note about pull requests
* Show ccache stats even on failure
* Add spack-based CI build
* Add spack build to push/pr
* Mark failing builds as experimental
* Fix missing compiler/version from matrix
* Use patched geant4 in upstream spack
* Use only celer buildcache
* Shorten padded length
* Don't push the buildcache...
* Load version information to fix examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation, examples, tests, and CI enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants