Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Geant4 build from 10.5–10.7 and example build for 11.1 onward #1152

Merged
merged 9 commits into from
Mar 18, 2024
Merged

Fix Geant4 build from 10.5–10.7 and example build for 11.1 onward #1152

merged 9 commits into from
Mar 18, 2024

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Mar 15, 2024

  • Const correctness issues caused some breakage with Geant4 10.5-10.7
  • G4 run manager factory was required for examples but is only present in 11.0 and higher
  • Issues with the new geant4 cmake variable cache break xercesc importing for 11.1–11.2

TODO: wait for #1149 to merge, then remove the 'experimental' status on the failing builds

@sethrj sethrj added bug Something isn't working external Dependencies and framework-oriented features labels Mar 15, 2024
@sethrj sethrj requested review from drbenmorgan and pcanal March 15, 2024 17:50
@sethrj sethrj mentioned this pull request Mar 15, 2024
Merged
2 tasks
drbenmorgan
drbenmorgan approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@drbenmorgan drbenmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good @sethrj, LGTM!

@sethrj sethrj merged commit edc9be8 into celeritas-project:develop Mar 18, 2024
26 of 27 checks passed
@sethrj sethrj deleted the fix-geant4-old branch March 18, 2024 16:20
sethrj added a commit that referenced this pull request Mar 18, 2024
@sethrj
Fix Geant4 build from 10.5–10.7 and example build for 11.1 onward (#1152
c10881e 
)

* Add additional components in CeleritasConfig
* Remove obsolete requirement in CeleritasConfig
* Fix downstream (example) build with Geant4 11.1+
* Fix build for Geant4 10.5–10.7
* Fix example execution for Geant4@11.1+
* Add geant4 compatibility ranges
* Remove experimental status from geant builds
sethrj added a commit that referenced this pull request Mar 18, 2024
@sethrj
Fix Geant4 build from 10.5–10.7 and example build for 11.1 onward (#1152
6395a99 
)

* Add additional components in CeleritasConfig
* Remove obsolete requirement in CeleritasConfig
* Fix downstream (example) build with Geant4 11.1+
* Fix build for Geant4 10.5–10.7
* Fix example execution for Geant4@11.1+
* Add geant4 compatibility ranges
* Remove experimental status from geant builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drbenmorgan drbenmorgan drbenmorgan approved these changes

@pcanal pcanal Awaiting requested review from pcanal

Assignees
No one assigned
Labels
bug Something isn't working external Dependencies and framework-oriented features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sethrj @drbenmorgan