Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new track status and support user "initialization" #1294

Merged
merged 14 commits into from
Jul 2, 2024

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Jun 27, 2024

This defines an "error" status (to supporting a refactor of #1290) and an "initializing" status, which is set whenever a track slot starts its life. A new user_start action order allows users to set custom data that applies only to new tracks. I split the Stepper test into two, one of which requires Geant4 and the other which uses built-in data.

Changes:

  • Rename post_post to user_post, and post_pre to user_pre
  • "Not inactive" and "alive" are now different
  • Slightly changed TrackSortUtils

Do we also want to add a Stepper output for "errored" tracks? 🤔

@sethrj sethrj added enhancement New feature or request physics Particles, processes, and stepping algorithms labels Jun 27, 2024
@sethrj sethrj requested review from amandalund and esseivaju June 27, 2024 21:47
@amandalund
Copy link
Contributor

I think this is a good idea! Before I look too closely, are the stepper tests a straight up refactoring, or did you make changes?

@sethrj
Copy link
Member Author

sethrj commented Jun 29, 2024

The stepper tests basically got moved. There's one or two new tests in the Stepper, and almost everything got directly moved to StepperGeant which you can ignore

Copy link
Contributor

@amandalund amandalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @sethrj!

@sethrj sethrj enabled auto-merge (squash) July 2, 2024 19:22
@sethrj sethrj merged commit b883168 into celeritas-project:develop Jul 2, 2024
29 checks passed
@sethrj sethrj deleted the status-and-actions branch July 3, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request physics Particles, processes, and stepping algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants