-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new track status and support user "initialization" #1294
Conversation
I think this is a good idea! Before I look too closely, are the stepper tests a straight up refactoring, or did you make changes? |
The stepper tests basically got moved. There's one or two new tests in the Stepper, and almost everything got directly moved to StepperGeant which you can ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @sethrj!
This defines an "error" status (to supporting a refactor of #1290) and an "initializing" status, which is set whenever a track slot starts its life. A new
user_start
action order allows users to set custom data that applies only to new tracks. I split theStepper
test into two, one of which requires Geant4 and the other which uses built-in data.Changes:
post_post
touser_post
, andpost_pre
touser_pre
TrackSortUtils
Do we also want to add a
Stepper
output for "errored" tracks? 🤔