Fix device test failures #1307
Merged
Fix device test failures #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amandalund
added
documentation
sethrj
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Sorry about that! We haven't had reliable "actually run the test on device" CI for so long (but it hasn't been an issue since we haven't run much low level stuff). I'll make sure to run future tests on wildstyle before pushing if we don't have CI.
Maybe you can also incorporate #1303 (comment) into this PR?
| @@ -256,7 +256,7 @@ TEST_F(TestTrackPartitionEm3Stepper, | |||
| return std::is_partitioned( | |||
| span.begin(), span.end(), [&track_status](auto const track_slot) { | |||
| return track_status[TrackSlotId{track_slot}] | |||
| == TrackStatus::alive; | |||
| != TrackStatus::inactive; | |||
There was a problem hiding this comment.
This is because I must not have run this test on device—sorry!
| @@ -249,7 +249,7 @@ TEST_F(TestEm3DiagnosticTest, TEST_IF_CELER_DEVICE(device)) | |||
| EXPECT_VEC_EQ(expected_steps, result.steps); | |||
|
|
|||
| EXPECT_JSON_EQ( | |||
| R"json({"_category":"result","_index":["particle","action"],"_label":"action-diagnostic","actions":[[0,0,0,0,0,0,0,3,0,0,0,0,0,0,0,0,0,0,0,0,9,0],[0,0,0,996,0,0,2,0,0,0,0,20,509,0,0,0,0,0,0,0,521,0],[0,0,0,902,0,0,10,0,0,0,9,20,577,0,0,0,0,0,0,0,518,0]]})json", | |||
| R"json({"_category":"result","_index":["particle","action"],"_label":"action-diagnostic","actions":[[0,0,0,0,0,0,0,3,0,0,0,0,0,0,0,0,0,0,0,0,0,9,0],[0,0,0,996,0,0,2,0,0,0,0,20,509,0,0,0,0,0,0,0,0,521,0],[0,0,0,902,0,0,10,0,0,0,9,20,577,0,0,0,0,0,0,0,0,518,0]]})json", | |||
…hecker device test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm seeing a few test failures after #1294 and #1303 (not sure why the CI didn't catch them). There's still one failure in the
StatusCheckertest I haven't looked into yet.