Remove MSC data from core physics class #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
physics
whokion
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on from work done in #457 with the goal of physics class (builders, etc.) for #253 . It removes the MSC process from physics processing and puts particle- and material-dependent MSC data in the UrbanMsc class itself.
Since now the only purpose of passing the MscProcess into the physics is to construct the model that gets looked up by the
AlongStepUniformMscAction, we'll want a follow-on PR to remove the MSC "process" and Urban "model" entirely since these aren't treated the same way as all the other discrete and along-step processes in the code. At that point we can add the high-energy MSC model and consider how to simplify and combine the different along-step actions.