Remove multiple scattering from Processes #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
physics
sethrj
requested review from
amandalund and
whokion
and removed request for
amandalund
sethrj
commented
Feb 3, 2023
| auto msc_action = make_shared<ImplicitPhysicsAction>( | ||
| action_reg.next_id(), | ||
| "msc-range", | ||
| "range limitation due to multiple scattering"); |
There was a problem hiding this comment.
This is a bit of a hack too... but with the current AlongStepFactory implementation we can't create new implicit IDs when loading the MSC parameters 🤔 but I think a solution may become apparent down the line.
amandalund
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
Looks good to me @sethrj! There's just the accel example that needs to be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #604 on the long road to #253 . It moves the MSC process/model data out of the purview of the Physics class since it doesn't affect the energy loss or have a discrete action.
In the process it changes the ImportData (and corresponding ROOT format), so MSC models have their own top-level entry next to processes. They have very different data layouts and needs; Geant4 shoehorns them into that class.
I'm not sure of the updated file organization (a new
em/mscdirectory) ... how and where to put the different MSC helper functions. Should we for example putUrbanMscParamsdirectly inem/sinceFluctuationParamsare there?Important : this is a backward incompatible change so the merge commit for this branch should be marked as v0.3.0-dev.