Add UniformAlongStepFactory for Geant4 integration #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
enhancement
whokion
approved these changes
Mar 27, 2023
sethrj
changed the title
|
@whokion I saw you approved this, but do you have any further comments before merging? Does the new ability to set the magnetic field look ok? |
|
@sethrj Sorry for the delay! Looks good to go (with the change for the exception related to |
|
Not a problem, thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a helper class
UniformAlongStepFactorythat translates aG4ThreeVectorwith the field magnitude in native CLHEP/G4 units to an along-step action. I also made a few minor quality of life improvements to the MT logger.