Merge duplicate definitions with testutil

[vidhanarya]

Subtask for #832

Found duplicated function definitions for generateRandomlySizedTransactions and generateRandomlySizedBlobs
Example ref:
generateRandomlySizedTransaction(s)

celestia-app/pkg/shares/shares_test.go

Line 109 in 8b3dacb

func generateRandomlySizedTransactions(count, maxSize int) coretypes.Txs {

celestia-app/pkg/shares/shares_test.go

Line 121 in 8b3dacb

func generateRandomTransaction(count, size int) coretypes.Txs {

celestia-app/pkg/prove/proof_test.go

Line 189 in 8b3dacb

func generateRandomlySizedTxs(count, max int) types.Txs {

celestia-app/pkg/prove/proof_test.go

Line 201 in 8b3dacb

func generateRandomTxs(count, size int) types.Txs {

Identified Duplicates:

Duplicates	Packages
generateRandomlySizedTransactions,generateRandomlySizedTxs	shares,prove
generateRandomTransaction, generateRandomTxs	shares,prove
generateRandomlySizedBlobs	shares,prove
generateRandomBlob	shares,prove
GenerateKeyringSigner, generateKeyringSigner, generateKeyring	app, app_test, testutil, x/blob/types
GenerateManyRawWirePFB, GenerateManyRawSendTxs, generateRawTx, generateManyRawWirePFB, generateManyRawSendTxs	app, app_test, blobtestutil

Proposal:

• Create a factory package inside testutil and move all these generators to factory package

[vidhanarya]

@evan-forbes @rootulp let me know if this proposal works. I have started working on the changes and can raise a PR if no concerns.

Also, couldn't find any epic to link this issue, can someone point me to that if any?
Reason: Have a few concerns/proposals (all comes under the testing label) regarding the domain of other packages as well - for example:

1. test_util.go in the app package collides with the domain of testutil package
2. Constant declarations of common variables for testing purposes in individual test files (eg. testAccName in builder_test.go) instead of a single source in testutil (eg. test_constants.go)

Ref:

1. celestia-app/app/test/prepare_proposal_test.go

   Line 183 in 8b3dacb

   testAccName = "test-account"

2. Not in use?
   

   celestia-app/app/test_util.go

   Line 22 in 8b3dacb

   func GenerateValidBlockData(

3. Duplicates
   

   celestia-app/app/test_util.go

   Line 53 in 8b3dacb

   func generateManyRawWirePFB(t *testing.T, txConfig client.TxConfig, signer *types.KeyringSigner, count, size int) [][]byte {

   
   

   celestia-app/testutil/blob/testutil.go

   Line 21 in 8b3dacb

   func GenerateManyRawWirePFB(t *testing.T, txConfig client.TxConfig, signer *types.KeyringSigner, count, size int) [][]byte {

[rootulp]

Also, couldn't find any epic to link this issue, can someone point me to that if any?

I don't think this falls into an existing epic but we can def answer your other questions without an epic assigned.

test_util.go in the app package collides with the domain of testutil package

I get confused by the number of testutil things in this repo. I like your name proposal for a factory package that contains generate* functions.

Constant declarations of common variables for testing purposes in individual test files

I don't think there's a ton of value to be gained by consolidating constants used in test files but I'm not against it. For a bit of context, a PR author may create a new constant while writings tests for their PR because they're unaware that another constant may suffice.

I think there is value in consolidating all the generate* functions you've done in #1074 because now future PRs shouldn't need to copy + paste this code around for setting up data in tests.

Not in use?

If not in use, let's delete it 🪓 . CI should fail if it is needed.