-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate utility testing functions where possible #832
Comments
@evan-forbes I can work on this issue. Can you point me to the files to get started? |
A candidate sub-task for this issue is to delete the duplicate definitions of
The last function definition is the most preferred because it accounts for the parity and tail padding namespaces. Note: the duplicate functions are defined in different packages so the last function may need to be extracted to a package that can be imported by all usages of the duplicate definitions. |
@rootulp @evan-forbes can we define a scope for this issue? We can not achieve all the changes in one PR. If we can scope them, it would be easier to work on |
Spun out #836 in-case @evan-forbes has other ideas for what this issue should include. |
another instance per this #1991 (comment) |
Closing this b/c it's not actionable. Please re-open or create a new issue with more specific examples of the redundant testing utilities that need consolidation. |
As we've discussed synchronously many times, there's quite a bit of redundant testing utility functions. We should consolidate where possible. If its not possible due to cyclic imports, then we should consider putting those tests in their own package.
related to #829
The text was updated successfully, but these errors were encountered: