chore!: refactor testnode to expose appcreator #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
commented
Jun 27, 2023
Comment on lines
+35
to
+36
| // AppCreator is used to create the application for the testnode. | ||
| AppCreator srvtypes.AppCreator |
There was a problem hiding this comment.
per #1990, we can now replace this function with a new one that creates a malicious applicaiton
Codecov Report
@@ Coverage Diff @@
## main #1991 +/- ##
==========================================
- Coverage 21.49% 21.43% -0.07%
==========================================
Files 122 123 +1
Lines 13817 13856 +39
==========================================
Hits 2970 2970
- Misses 10558 10597 +39
Partials 289 289
|
evan-forbes
added
the
testing
cmwaters
approved these changes
Jun 27, 2023
| // genesis state and consensus parameters. The provided keyring is used to | ||
| // create a validator key and the chainID is used to initialize the genesis | ||
| // state. The keyring is returned with the validator account added. | ||
| func InitFiles( |
There was a problem hiding this comment.
I have a similar function in the e2e directory. Maybe as a followup we could look to consolidate
This was referenced Jun 27, 2023
evan-forbes
added a commit
that referenced
this pull request
Jul 3, 2023
## Overview This refactor is mainly targeting #1990, but doing so in a way that uses common patters to avoid continuing to blow up the api closes #1990 ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords
evan-forbes
added a commit
that referenced
this pull request
Jul 3, 2023
## Overview This refactor is mainly targeting #1990, but doing so in a way that uses common patters to avoid continuing to blow up the api closes #1990 ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords
5 tasks
evan-forbes
added a commit
that referenced
this pull request
Jul 6, 2023
This reverts commit 59ae663.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This refactor is mainly targeting #1990, but doing so in a way that uses common patters to avoid continuing to blow up the api
closes #1990
Checklist