Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override BaseProposerReward and BonusProposerReward to 0% #2716

Closed
rootulp opened this issue Oct 18, 2023 · 0 comments · Fixed by #2717
Closed

Override BaseProposerReward and BonusProposerReward to 0% #2716

rootulp opened this issue Oct 18, 2023 · 0 comments · Fixed by #2717
Assignees
@rootulp

Comments

@rootulp
Copy link
Collaborator

rootulp commented Oct 18, 2023 •
edited
Loading

Context

We overrode the distribution module's BaseProposerReward and BonusProposerReward in celestiaorg/cosmos-sdk#309 to 0%. However, that change was subsequently reverted in celestiaorg/cosmos-sdk#339 b/c the override was made in cosmos-sdk and we pulled upstream changes from cosmos-sdk.

Problem

We want to set both of these params to 0. Note they are already 0 in the specs

Proposal

Make this change in celestia-app so we don't accidentally revert it again.
@rootulp rootulp self-assigned this Oct 18, 2023
@rootulp rootulp mentioned this issue Oct 18, 2023
Merged
@rootulp rootulp changed the title Override BaseProposerReward and BonusProposerReward to 0 Override BaseProposerReward and BonusProposerReward to 0% Oct 18, 2023
@rootulp rootulp added this to the Mainnet milestone Oct 18, 2023
rootulp added a commit that referenced this issue Oct 19, 2023
@rootulp
fix: override proposer rewards to 0% (#2717)
dfd9959 
Closes #2716

## Testing

```bash
./scripts/single-node.sh
cat ~/.celestia-app/config/genesis.json
```

### Before

```genesis.json
    "distribution": {
      "params": {
        "community_tax": "0.020000000000000000",
        "base_proposer_reward": "0.010000000000000000",
        "bonus_proposer_reward": "0.040000000000000000",
        "withdraw_addr_enabled": true
      },
```

### After

```genesis.json
    "distribution": {
      "params": {
        "community_tax": "0.020000000000000000",
        "base_proposer_reward": "0.000000000000000000",
        "bonus_proposer_reward": "0.000000000000000000",
        "withdraw_addr_enabled": true
      },
```
mergify bot pushed a commit that referenced this issue Oct 19, 2023
@rootulp @mergify
fix: override proposer rewards to 0% (#2717)
95532c5 
Closes #2716

## Testing

```bash
./scripts/single-node.sh
cat ~/.celestia-app/config/genesis.json
```

### Before

```genesis.json
    "distribution": {
      "params": {
        "community_tax": "0.020000000000000000",
        "base_proposer_reward": "0.010000000000000000",
        "bonus_proposer_reward": "0.040000000000000000",
        "withdraw_addr_enabled": true
      },
```

### After

```genesis.json
    "distribution": {
      "params": {
        "community_tax": "0.020000000000000000",
        "base_proposer_reward": "0.000000000000000000",
        "bonus_proposer_reward": "0.000000000000000000",
        "withdraw_addr_enabled": true
      },
```

(cherry picked from commit dfd9959)
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp
fix: override proposer rewards to 0% (#2717)
e3dfd17 
Closes celestiaorg/celestia-app#2716

## Testing

```bash
./scripts/single-node.sh
cat ~/.celestia-app/config/genesis.json
```

### Before

```genesis.json
    "distribution": {
      "params": {
        "community_tax": "0.020000000000000000",
        "base_proposer_reward": "0.010000000000000000",
        "bonus_proposer_reward": "0.040000000000000000",
        "withdraw_addr_enabled": true
      },
```

### After

```genesis.json
    "distribution": {
      "params": {
        "community_tax": "0.020000000000000000",
        "base_proposer_reward": "0.000000000000000000",
        "bonus_proposer_reward": "0.000000000000000000",
        "withdraw_addr_enabled": true
      },
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: override proposer rewards to 0% rootulp/celestia-app
1 participant
@rootulp