chore!: align staking module with mainline SDK #339
Conversation
| NOTE DIFF FROM UPSTREAM: All proposals must have at least one `sdk.Msg` in the `messages` field. | ||
|
|
There was a problem hiding this comment.
Note that this will now be enforced on celestia-app here: https://github.com/celestiaorg/celestia-app/blob/cb8247ead807a52bb8915d450982544755efc1e6/app/ante/gov.go#L17
| // Check if no Messages are proposed | ||
| if len(m.Messages) == 0 { | ||
| return sdkerrors.Wrap(types.ErrNoProposalMsgs, "Msgs length must be non-zero") | ||
| // Check that either metadata or Msgs length is non nil. | ||
| if len(m.Messages) == 0 && len(m.Metadata) == 0 { | ||
| return sdkerrors.Wrap(types.ErrNoProposalMsgs, "either metadata or Msgs length must be non-nil") | ||
| } |
There was a problem hiding this comment.
This is now enforced in celestia-app here: https://github.com/celestiaorg/celestia-app/blob/cb8247ead807a52bb8915d450982544755efc1e6/app/ante/gov.go#L17
There was a problem hiding this comment.
Not blocking on this since its not part of the staking module, but for posterity I think we can also remove
cosmos-sdk/client/flags/flags.go
Line 90 in 7753abe
…rds compatibility (cosmos#13448) * split ExportGenesis into two functions to maintain backwards compatibility (#339) * fix tests Co-authored-by: Nicolas Lara <nicolaslara@gmail.com>
| if serverCtx.DefaultConsensusParams != nil { | ||
| genDoc.ConsensusParams = serverCtx.DefaultConsensusParams | ||
| } |
There was a problem hiding this comment.
it looks like we accidently removed our ability to set default consensus parameters
Description
Closes: #338
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change