feat: allow for the default consensus params to be set by the applica… #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion (#317) * feat: allow for the default consensus params to be set by the application * chore: add test * fix: spelling Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com> --------- Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
5 tasks
Codecov Report
@@ Coverage Diff @@
## release/v0.46.x-celestia #345 +/- ##
============================================================
- Coverage 65.57% 65.55% -0.03%
============================================================
Files 666 666
Lines 71177 71180 +3
============================================================
- Hits 46677 46661 -16
- Misses 21916 21936 +20
+ Partials 2584 2583 -1
|
5 tasks
rootulp
approved these changes
Sep 4, 2023
liamsi
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
we [afaiu] accidently removed our ability to change the default consesus parameters in #339
this PR re-cherry-picks #317 to fix