chore: update more default parameters #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
added
gov param
rootulp
previously approved these changes
Sep 4, 2023
liamsi
reviewed
Sep 4, 2023
evan-forbes
commented
Sep 4, 2023
There was a problem hiding this comment.
tested quickly locally, but noticed that we accidently lost our ability to change the default consensus params
fixed here celestiaorg/cosmos-sdk#345
5 tasks
liamsi
previously approved these changes
Sep 5, 2023
rootulp
previously approved these changes
Sep 5, 2023
cmwaters
reviewed
Sep 11, 2023
|
On second thought, I think we should update the specs params.md file and the actual param in the same PR b/c I think there are a few inconsistencies and it isn't clear what the desired value for each param is. |
|
|
alrighty, I've updated both the specs and the default values here to the values that were discussed synchronously! this PR is ready for review |
rootulp
reviewed
Sep 13, 2023
| | consensus.evidence.MaxAgeDuration | 1814400000000000 (21 days) | The maximum age of evidence before it is considered invalid in nanoseconds. This value should be identical to the unbonding period. | True | | ||
| | consensus.evidence.MaxBytes | 1MiB | Maximum size in bytes used by evidence in a given block. | True | | ||
| | consensus.validator.PubKeyTypes | Ed25519 | The type of public key used by validators. | False | | ||
| | consensus.Version.AppVersion | 1 | Determines protocol rules used for a given height. Incremented by the application upon an upgrade. | False | | ||
| | distribution.communitytax | 2.0% | Percentage of the inflation sent to the community pool. | True | | ||
| | distribution.CommunityTax | 2.0% | Percentage of the inflation sent to the community pool. | True | |
Co-authored-by: Rootul P <rootulp@gmail.com>
Co-authored-by: Rootul P <rootulp@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2417 +/- ##
==========================================
- Coverage 20.61% 20.59% -0.03%
==========================================
Files 131 131
Lines 15270 15301 +31
==========================================
+ Hits 3148 3151 +3
- Misses 11820 11847 +27
- Partials 302 303 +1
|
This was
linked to
issues
Sep 13, 2023
rootulp
approved these changes
Sep 14, 2023
mergify bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
## Overview minor update to the defaults to match #2416. ofc, these are not consensus breaking as they're just changes to the defaults. This saves us from having to manually change this for mainnet or mocha ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords --------- Co-authored-by: Rootul P <rootulp@gmail.com> (cherry picked from commit 9fa9fbf) # Conflicts: # app/default_overrides.go
evan-forbes
added a commit
that referenced
this pull request
Sep 14, 2023
This is an automatic backport of pull request #2417 done by [Mergify](https://mergify.com). Cherry-pick of 9fa9fbf has failed: ``` On branch mergify/bp/v1.x/pr-2417 Your branch is up to date with 'origin/v1.x'. You are currently cherry-picking commit 9fa9fbf. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Changes to be committed: modified: app/app.go modified: app/default_overrides_test.go modified: pkg/appconsts/consensus_consts.go modified: specs/src/specs/params.md Unmerged paths: (use "git add <file>..." to mark resolution) both modified: app/default_overrides.go ``` To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> --------- Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com> Co-authored-by: evan-forbes <evan.samuel.forbes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
minor update to the defaults to match #2416. ofc, these are not consensus breaking as they're just changes to the defaults. This saves us from having to manually change this for mainnet or mocha
Closes #2480 #2476
Checklist