Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: consistent format for percentages in params.md #2492

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Sep 13, 2023

Closes #2479

@rootulp rootulp added documentation Improvements or additions to documentation specs directly relevant to the specs labels Sep 13, 2023
@rootulp rootulp added this to the Mainnet milestone Sep 13, 2023
@rootulp rootulp self-assigned this Sep 13, 2023
@celestia-bot celestia-bot requested a review from a team September 13, 2023 18:35
@codecov-commenter
Copy link

Codecov Report

Merging #2492 (856d943) into main (0012451) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2492   +/-   ##
=======================================
  Coverage   20.62%   20.62%           
=======================================
  Files         131      131           
  Lines       15275    15275           
=======================================
  Hits         3151     3151           
  Misses      11821    11821           
  Partials      303      303           

cmwaters
cmwaters previously approved these changes Sep 14, 2023
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

evan-forbes
evan-forbes previously approved these changes Sep 14, 2023
@rootulp rootulp dismissed stale reviews from evan-forbes and cmwaters via 0362953 September 14, 2023 14:45
@celestia-bot celestia-bot requested a review from a team September 14, 2023 14:45
@rootulp rootulp enabled auto-merge (squash) September 14, 2023 14:45
@rootulp rootulp added the backport:v1.x PR will be backported automatically to the v1.x branch upon merging label Sep 14, 2023
@rootulp rootulp merged commit 87f158c into celestiaorg:main Sep 18, 2023
24 checks passed
mergify bot pushed a commit that referenced this pull request Sep 18, 2023
@rootulp rootulp deleted the rp/consistent-param-percentages branch September 18, 2023 13:58
rootulp added a commit that referenced this pull request Sep 18, 2023
…#2525)

This is an automatic backport of pull request #2492 done by
[Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the
[documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on
`<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you
can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

Co-authored-by: Rootul P <rootulp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:v1.x PR will be backported automatically to the v1.x branch upon merging documentation Improvements or additions to documentation specs directly relevant to the specs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent format for percentages in params.md
4 participants