Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for state sync #3807

Open
rootulp opened this issue Aug 22, 2024 · 0 comments
Open

Add a test for state sync #3807

rootulp opened this issue Aug 22, 2024 · 0 comments
Assignees
@evan-forbes
Labels
knuu item is directly related to the usage of knuu priority:high optional label to track the relative priority of planned items testing items that are strictly related to adding or extending test coverage WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc

Comments

@rootulp
Copy link
Collaborator

rootulp commented Aug 22, 2024

Context

#3804

Problem

We discovered a bug with state sync on a testnet. Ideally this should've been caught via a unit or integration test.

Proposal

Add a test that tries to state sync in a manner that will catch regressions like #3804
@rootulp rootulp added the testing items that are strictly related to adding or extending test coverage label Aug 22, 2024
@rootulp rootulp mentioned this issue Aug 22, 2024
Merged
rootulp added a commit that referenced this issue Aug 22, 2024
@rootulp @cmwaters
fix: state sync on v2.x (#3808)
fb79af5 
Closes #3804 with a
hacky approach that infers the app version based on the snapshot height
and mounts KV stores accordingly.

Kinda related to #3804
but we didn't hit this because we don't have tests that try to state
sync so I created
#3807

## Testing

Using both the `arabica.sh` and `mocha.sh` scripts in this PR, I can
start state syncing. I let the Arabica node fully state sync to the tip
of the chain and it worked.

---------

Co-authored-by: Callum Waters <cmwaters19@gmail.com>
@evan-forbes evan-forbes added the priority:high optional label to track the relative priority of planned items label Aug 25, 2024
@evan-forbes evan-forbes mentioned this issue Aug 25, 2024
Closed
@rootulp rootulp added the knuu item is directly related to the usage of knuu label Oct 7, 2024
@evan-forbes evan-forbes added the WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc label Oct 11, 2024
@evan-forbes evan-forbes self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evan-forbes evan-forbes

Labels
knuu item is directly related to the usage of knuu priority:high optional label to track the relative priority of planned items testing items that are strictly related to adding or extending test coverage WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rootulp @evan-forbes