-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: state sync on v2.x #3808
fix: state sync on v2.x #3808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might want to mention somewhere in the scripts or in their names that they do statesync, but not blocking
thanks for testing state sync!! great catch. ideally we test this with knuu
I am going to test this out manually. If it passes we can merge this for now and then work on adding it to the e2e tests and a more long term fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So long as everything is green this should be good to merge
Closes #3804 with a hacky approach that infers the app version based on the snapshot height and mounts KV stores accordingly.
Kinda related to #3804 but we didn't hit this because we don't have tests that try to state sync so I created #3807
Testing
Using both the
arabica.sh
andmocha.sh
scripts in this PR, I can start state syncing. I let the Arabica node fully state sync to the tip of the chain and it worked.