Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: implement full antehandler checks #1984

Merged
merged 6 commits into from
Jun 23, 2023
Merged

Conversation

cmwaters
Copy link
Contributor

Closes: #1937

@cmwaters cmwaters self-assigned this Jun 22, 2023
@MSevey MSevey requested a review from a team June 22, 2023 14:36
@cmwaters cmwaters changed the title fix: implement full antehandler checks fix!: implement full antehandler checks Jun 22, 2023
rootulp
rootulp previously approved these changes Jun 22, 2023
Base automatically changed from cal/fix-sig-validity to main June 22, 2023 15:33
@cmwaters cmwaters dismissed rootulp’s stale review June 22, 2023 15:33

The base branch was changed.

@MSevey MSevey requested a review from a team June 22, 2023 15:34
rootulp
rootulp previously approved these changes Jun 22, 2023
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

@cmwaters cmwaters merged commit 4802572 into main Jun 23, 2023
@cmwaters cmwaters deleted the cal/full-antehandler-checks branch June 23, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non PFB txs need also pass validity checks
3 participants